Shape related code updated to address TODO(b/208879020) #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When read_raw_data_for_training is set to False when invoking the main function, common.transform_data was being called on raw train and test data anyway. This fix moves the transformation to the block where read_raw_data_for_training is True. The scenario here is the data has already been preprocessed, and the user wishes to re-use that preprocessed data.
Since this is tabular data we're dealing with, the code has been updated to treat it as such. The net result is simpler shape related code. Education-num is treated as dense here instead of sparse as it was before. It might be missing values in the data, so it might call for some sort of imputation to be done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of change
Shape related code has been updated to treat each observation as a tensor of shape (1,).
Details
The feature spec is updated to use shape (1,), and therefore the schema as well.
education-numis now treated as a dense tensor instead of sparse as it may be missing values, but it does not vary in its length to warrant treatment as aRaggedTensor.transform_datasetis updated to reshape the raw data so each observation is transformed to be of shape (1,) before passing throughtft_layer. This pull request includes pr268. I am open to making them independent of each other and any other feedback. I would like to make a notebook version of this example that walks through the entire lifecycle of the workflow in the context of tft. The details are in that pull request, but I would like to expand it to be more instructive through interactivity.