Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shape related code updated to address TODO(b/208879020) #270

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Commits on May 6, 2022

  1. Fix to only transform raw data when requested.

    When read_raw_data_for_training is set to False when invoking the main
    function, common.transform_data was being called on raw train and test
    data anyway.  This fix moves the transformation to the block where
    read_raw_data_for_training is True. The scenario here is the data has
    already been preprocessed, and the user wishes to re-use that
    preprocessed data.
    pritamdodeja committed May 6, 2022
    Configuration menu
    Copy the full SHA
    93427dc View commit details
    Browse the repository at this point in the history

Commits on May 10, 2022

  1. Shape related code is simplified by using (1,).

    Since this is tabular data we're dealing with, the code has been
    updated to treat it as such.  The net result is simpler shape related
    code.  Education-num is treated as dense here instead of sparse as it
    was before.  It might be missing values in the data, so it might call
    for some sort of imputation to be done.
    pritamdodeja committed May 10, 2022
    Configuration menu
    Copy the full SHA
    6e24dc3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cd28097 View commit details
    Browse the repository at this point in the history