add hpm6200 family usb id #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
HPM6200有板子测试过。又添加了HPM6800和HPM5300，没有板子测试，不过看起来是能正常工作的。昨天看着vid和pid不对劲，今天翻文档找HPM6800和HPM5300的vid确认了一下，代码里面vid和pid被交换了。 |
tfx2001
reviewed
Mar 12, 2024
| @@ -13,6 +13,9 @@ use crate::isp_command::{Error, Interface, IspCommand, Packet}; | |||
| enum Family { | |||
| HPM6700_6400 = 0x0001, | |||
| HPM6300 = 0x0002, | |||
| HPM6200 = 0x0003, | |||
There was a problem hiding this comment.
看了下 6200 的 UM，手册中 PID 写的是 0x0002，但我手上 6300 的板子 PID 也是 0x0002，应该是手册描述有误，先给你合了。感谢 PR。
There was a problem hiding this comment.
刚看到，6200我开始是没看手册的，直接尝试使用发现一直报错无法打开USB设备。改了代码打印USB信息，然后找到同vid的设备有一个pid是0x0003，添加之后能识别到芯片了。刚检查UM确实手册不对，下次有机会给厂家反馈一下。看后面的手册他顺序都是递增的，应该只有这个6200的pid写错了。感谢作者大大的优秀软件😀
tfx2001
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned, i can read the flash content in the actual test.
如题，实测能读取到flash内容