Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add V2I feature to Shinjuku sample scene #175

Merged
merged 10 commits into from
Sep 6, 2023
Merged

Add V2I feature to Shinjuku sample scene #175

merged 10 commits into from
Sep 6, 2023

Conversation

lchojnack
Copy link
Contributor

@lchojnack lchojnack commented Aug 7, 2023 •
edited
Loading

This PR is an extension of PR #109

New features:

  1. Add relationID and wayID from lanelet to TrafficLight GameObject (more details here) in Nishinjuku Random Traffic prefab. Several screenshots from verification below.

Screenshot_20230814_150427
Screenshot_20230814_150312
Screenshot_20230814_150212

  1. Add V2I feature to Shinjuku scene (enabled by default)
image image
  1. Add to the V2I feature a possibility to select if as traffic_signal_id field in msg is Relation ID or Way ID.
    V2I feature can be used as Traffic Light ground truth information, and for that usage Way ID is supposed to be selected.
image Screenshot_20230808_162747

@lchojnack
feat(v2i): change publishing way id to relation id as traffic signal …
4edbe07 
…id msg field

Signed-off-by: Lukasz Chojnacki <[email protected]>
@lchojnack
feat(v2i): add possibility to select if way id or relation id is used…
0420763 
… as traffic signal id msg field

Signed-off-by: Lukasz Chojnacki <[email protected]>
@lchojnack
Merge branch 'main' into feature/v2i-scene
40b844a
@lchojnack
Fix for filling TrafficLight GameObject with ll2 relationId and wayID
b2177a1 
Signed-off-by: Lukasz Chojnacki <[email protected]>
@lchojnack
Add ll2 relationID and wayID to TrafficLight GameObject
b4c45c6 
Signed-off-by: Lukasz Chojnacki <[email protected]>
@lchojnack
Add V2I feature to AutowareSimulation scene and NishishinjukuRandomTr…
8c767bf 
…affic prefab

Signed-off-by: Lukasz Chojnacki <[email protected]>
@lchojnack
Disable V2I feature by default
bdf17a4 
Signed-off-by: Lukasz Chojnacki <[email protected]>
@lchojnack lchojnack marked this pull request as ready for review August 14, 2023 13:22
@lchojnack
Enable V2I feature in AutowareSimulation scene
0c5789d 
Signed-off-by: Lukasz Chojnacki <[email protected]>
@lchojnack
Used V2I prefab
950b164 
Signed-off-by: Lukasz Chojnacki <[email protected]>
@lchojnack lchojnack changed the title V2I sample scene Add V2I feature to Shinjuku sample scene Aug 14, 2023
@mackierx111
Copy link
Collaborator

LGTM!

I have turned off the v2i setting by default, as Autoware is not yet supposed to always use v2i.
image

@mackierx111 mackierx111 merged commit 0e70e3f into main Sep 6, 2023
2 checks passed
@mackierx111 mackierx111 deleted the feature/v2i-scene branch September 6, 2023 07:14
@lchojnack
Copy link
Contributor Author

lchojnack commented Sep 6, 2023 •
edited
Loading

@mackierx111
Thank you for merging the PR

I've noticed that after the merge the trees disappeared in the main branch. I think it could happen by mistake.

Before the merge After the merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mackierx111 mackierx111 mackierx111 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lchojnack @mackierx111