Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix crop_box param name in ground_segmentation.param.yaml #1229

Closed
wants to merge 3 commits into from

Conversation

Autumn60
Copy link

@Autumn60 Autumn60 commented Apr 5, 2024

Description

Apply the parameter name changes in 0e1761a to ground_segmentation.param.yaml.

#1228

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Copy link

@badai-nguyen badai-nguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank your for your fixing. LGTM

@Autumn60 Autumn60 requested a review from YoshiRi as a code owner May 29, 2024 01:29
Copy link

sonarcloud bot commented Jul 7, 2024

@Autumn60 Autumn60 closed this Aug 20, 2024
@Autumn60 Autumn60 deleted the fix/ground_segmentation_config branch August 20, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect param names in ground_segmentation.param.yaml
3 participants