Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add feature to record multi-host system #262

Merged
merged 16 commits into from
May 10, 2024

Conversation

ymski
Copy link
Contributor

@ymski ymski commented Dec 26, 2023

Description

This PR adds feature to record multi-host system.

Related links

Notes for reviewers

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR has been properly tested.
  • The PR has been reviewed.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@codecov-commenter
Copy link

codecov-commenter commented Dec 28, 2023

Codecov Report

Attention: 46 lines in your changes are missing coverage. Please review.

Comparison is base (270ce2b) 24.99% compared to head (00a30d6) 36.89%.
Report is 8 commits behind head on main.

Files Patch % Lines
CARET_trace/test/test_trace_node.cpp 57.44% 0 Missing and 20 partials ⚠️
CARET_trace/test/test_scenario.cpp 13.63% 0 Missing and 19 partials ⚠️
CARET_trace/src/trace_node.cpp 56.25% 0 Missing and 7 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #262       +/-   ##
===========================================
+ Coverage   24.99%   36.89%   +11.89%     
===========================================
  Files          58       28       -30     
  Lines        3317     2136     -1181     
  Branches     1085     1112       +27     
===========================================
- Hits          829      788       -41     
+ Misses       1754      575     -1179     
- Partials      734      773       +39     
Flag Coverage Δ
differential 36.89% <45.88%> (?)
total ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ymski ymski marked this pull request as ready for review January 18, 2024 09:15
@ymski ymski changed the title feat: multihost feat: add feature to record multi-host system Jan 18, 2024
@isp-uetsuki isp-uetsuki self-requested a review January 18, 2024 09:53
CARET_trace/CMakeLists.txt Show resolved Hide resolved
CARET_trace/src/trace_node.cpp Outdated Show resolved Hide resolved
CARET_trace/src/trace_node.cpp Outdated Show resolved Hide resolved
CARET_trace/test/test_trace_node.cpp Show resolved Hide resolved
CARET_trace/test/test_trace_node.cpp Show resolved Hide resolved
CARET_trace/test/test_trace_node.cpp Outdated Show resolved Hide resolved
CARET_trace/test/test_trace_node.cpp Outdated Show resolved Hide resolved
CARET_trace/test/test_trace_node.cpp Outdated Show resolved Hide resolved
CARET_trace/test/test_trace_node.cpp Outdated Show resolved Hide resolved
CARET_trace/test/test_trace_node.cpp Outdated Show resolved Hide resolved
@isp-uetsuki
Copy link
Contributor

LGTM

@ymski ymski force-pushed the feat/add_multihost_trace branch from 00a30d6 to 5c41e8e Compare May 9, 2024 01:23
@xygyo77 xygyo77 self-requested a review May 10, 2024 08:29
Copy link
Contributor

@xygyo77 xygyo77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ymski ymski merged commit a0ff9fb into tier4:main May 10, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants