Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add feature to record multi-host system #163

Merged
merged 9 commits into from
May 10, 2024
Merged

feat: add feature to record multi-host system #163

merged 9 commits into from
May 10, 2024

Conversation

ymski
Copy link
Contributor

@ymski ymski commented Dec 26, 2023 •
edited
Loading

Description

This PR adds feature to record multi-host system.

Related links

Notes for reviewers

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR has been properly tested.
  • The PR has been reviewed.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@ymski ymski changed the title feat: multihost feat: add feature to record multi-host system Jan 18, 2024
This was referenced Jan 18, 2024
Merged
Merged
@isp-uetsuki isp-uetsuki self-requested a review January 18, 2024 09:54
isp-uetsuki
isp-uetsuki requested changes Jan 19, 2024
View reviewed changes
ros2caret/verb/chain_latency.py Outdated Show resolved Hide resolved
ros2caret/verb/record.py Outdated Show resolved Hide resolved
@isp-uetsuki
Copy link
Contributor

LGTM

isp-uetsuki
isp-uetsuki approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@isp-uetsuki isp-uetsuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ymski added 9 commits May 9, 2024 10:25
@ymski
check lttng session
6fe1448 
Signed-off-by: ymski <[email protected]>
@ymski
fix terminate order
243f373 
Signed-off-by: ymski <[email protected]>
@ymski
changed to be able to loads multiple trace data
2490e45 
Signed-off-by: ymski <[email protected]>
@ymski
Added message to check_ctf for loading multiple trace data. Verificat…
9df562f 
…ion of multiple trace data is not possible with CARET.

Signed-off-by: ymski <[email protected]>
@ymski
fix: modify method to verify the existence of an active lttng session
3573ddf 
Signed-off-by: ymski <[email protected]>
@ymski
remove unnecessary options
e99ab80 
Signed-off-by: ymski <[email protected]>
@ymski
remove unused funtions
8192885 
Signed-off-by: ymski <[email protected]>
@ymski
fix: remove type annotations for which no use case exists
b2f2c28 
Signed-off-by: ymski <[email protected]>
@ymski
fix: fix validate option when passing single data
e539cd0 
Signed-off-by: ymski <[email protected]>
@ymski ymski requested a review from xygyo77 May 10, 2024 08:19
xygyo77
xygyo77 approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@xygyo77 xygyo77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ymski ymski merged commit 0bf9117 into tier4:main May 10, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isp-uetsuki isp-uetsuki isp-uetsuki approved these changes

@xygyo77 xygyo77 xygyo77 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ymski @isp-uetsuki @xygyo77