feat: add relative path resolving to rulesetPath #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhaoyuheng200
force-pushed
the
rulesetPath
branch
from
16d689f
to
63ce589
Compare
zhaoyuheng200
force-pushed
the
rulesetPath
branch
4 times, most recently
from
22abd24
to
38f9d54
Compare
hyandell
reviewed
Oct 19, 2023
hyandell
reviewed
Oct 20, 2023
Signed-off-by: Neil Zhao <[email protected]>
Signed-off-by: Neil Zhao <[email protected]>
…pectation of error outcome Signed-off-by: Neil Zhao <[email protected]>
Instead of trying to resolve the file that doesn't exists and path too long (`system errors`), set `ruleset` to null in 38f9d5 for those scenarios to output those error as `application errors` Signed-off-by: Neil Zhao <[email protected]>
Signed-off-by: Neil Zhao <[email protected]>
zhaoyuheng200
force-pushed
the
rulesetPath
branch
from
ce925c8
to
5ca5edd
Compare
|
Thanks Neil :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When specifying
rulesetPathwith-roption, the rulesetPath will use the target repo path to resolve its relative path.This is not expected terminal behavior in most CLI tooling, the expectation is to resolve the relative path from the current path.
Proposed Changes
While maintaining the current implementation, the rulesetPath logic will try to use the context path if target repo path doesn't exist.
Test Plan
Updated test.