Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add relative path resolving to rulesetPath #306

Merged
merged 5 commits into from
Oct 27, 2023

Commits on Oct 25, 2023

  1. feat: add relative path resolving to rulesetPath

    Signed-off-by: Neil Zhao <[email protected]>
    zhaoyuheng200 committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    63dcfcf View commit details
    Browse the repository at this point in the history
  2. chore: add test case for

    Signed-off-by: Neil Zhao <[email protected]>
    zhaoyuheng200 committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    424dcec View commit details
    Browse the repository at this point in the history
  3. bugfix: keep the 'rulesetPath' resolve output to maintain customer ex…

    …pectation of error outcome
    
    Signed-off-by: Neil Zhao <[email protected]>
    zhaoyuheng200 committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    ee59322 View commit details
    Browse the repository at this point in the history
  4. chore: update test

    Instead of trying to resolve the file that doesn't exists and path too long  (`system errors`), set `ruleset` to null in 38f9d5 for those scenarios to output those error as `application errors`
    
    Signed-off-by: Neil Zhao <[email protected]>
    Neil Zhao authored and zhaoyuheng200 committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    46c4da0 View commit details
    Browse the repository at this point in the history
  5. chore: fix lint issue

    Signed-off-by: Neil Zhao <[email protected]>
    zhaoyuheng200 committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    5ca5edd View commit details
    Browse the repository at this point in the history