Refactor SysLog
#858
Merged
Refactor SysLog
#858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squell
force-pushed
the
rewrite-logger
branch
3 times, most recently
from
8079381
to
d9156af
Compare
auto-merge was automatically disabled
August 24, 2024 13:08
Pull request was converted to draft
squell
force-pushed
the
rewrite-logger
branch
2 times, most recently
from
c196450
to
e70f7ce
Compare
rnijveld
reviewed
Sep 5, 2024
rnijveld
reviewed
Sep 5, 2024
squell
force-pushed
the
rewrite-logger
branch
from
3c50c93
to
f2fcdb6
Compare
rnijveld
approved these changes
Sep 6, 2024
auto-merge was automatically disabled
September 6, 2024 10:18
Squash merges are not allowed on this repository
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues #809, #824 and #856 have all hit the same spot. Which is the same spot that gave rise to the infamous
vudoin original sudo (CVE 2001-0279). Luckily in safe Rust, the problems are contained topanicand hangs, but still: if you have metal pole in your garden where lightning has struck three times, it's probably wise to reconsider the pole.This PR disects and rewrites the old syslog code in a commit-by-commit basis. Enjoy.