Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor SysLog #858

Merged
merged 10 commits into from
Sep 6, 2024
Merged

Refactor SysLog #858

merged 10 commits into from
Sep 6, 2024

Commits on Sep 6, 2024

  1. create privacy between SysLogWriter and its user

    @squell
    squell committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    9d6b2a6 View commit details
    Browse the repository at this point in the history

  2. add Drop method to SysLogWriter

    @squell
    squell committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    a102907 View commit details
    Browse the repository at this point in the history

  3. split boundary calculation away from loop

    @squell
    squell committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    3173860 View commit details
    Browse the repository at this point in the history

  4. now we can clearly see this is a while loop

    @squell
    squell committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    8c01520 View commit details
    Browse the repository at this point in the history

  5. split off floor_char_boundary

    @squell
    squell committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    e51cc44 View commit details
    Browse the repository at this point in the history

  6. clearly state the contracts for suggested_break and other functions

    @squell
    squell committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    d696886 View commit details
    Browse the repository at this point in the history

  7. add test case against splitting UTF8 sequences (introduced by #857)

    @squell
    squell committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    112ce8d View commit details
    Browse the repository at this point in the history

  8. make test case pass

    @squell
    squell committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    dd2ee96 View commit details
    Browse the repository at this point in the history

  9. overhaul of suggested_break

    @squell
    squell committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    5267a20 View commit details
    Browse the repository at this point in the history

  10. incorporate comments by @rnijveld

    @squell
    squell committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    f2fcdb6 View commit details
    Browse the repository at this point in the history