Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LLM guide and profile.py to use new Triton+vLLM input names #412

Closed
wants to merge 3 commits into from

Conversation

matthewkotila
Copy link
Contributor

@matthewkotila matthewkotila commented Oct 9, 2023

@nv-hwoo
Copy link
Contributor

nv-hwoo commented Oct 10, 2023

Thanks for making the changes 👍 Can you also change the our documentation as well?

@matthewkotila
Copy link
Contributor Author

@nv-hwoo: Thanks for making the changes 👍 Can you also change the our documentation as well?

Done 👍

Copy link
Contributor

@dyastremsky dyastremsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR!

@matthewkotila
Copy link
Contributor Author

Handled in #442, closing

@matthewkotila matthewkotila deleted the matthewkotila-patch-1 branch November 30, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants