-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normalize input tensor names #59
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but need to sync with @nv-hwoo @matthewkotila for PA VLLM guide updates, and @pskiran1 for VLLM CI test updates.
L0_http/generate_endpoint_test.py
uses a mock model so it can be updated separately, should be unaffected by this.
Creates parity with triton-inference-server/tutorials#59
triton-inference-server/client#412 ready to go 👍🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit comment but LGTM. I ran the changes with PA LLM guide and confirmed that it works 👍
@tanmayv25, @jbkyang-nvi let me know if we want to merge this or close it as the changes have merged into the backend. |
What's still blocking this? |
@nnshah1 @tanmayv25 @rmccorm4 @jbkyang-nvi Friendly ping on what is blocking this? |
Plan is to move this tutorial to reference the new backend and the changes for naming have already been made there. We wanted to stop making changes here to avoid duplication / sync issues. @matthewkotila Let us know issues with that approach. |
updating to make names lower case and change 'prompt' and 'text' to more generic:
'text_input', 'text_output'