Merge pull request #595 from csazevedo/csazevedo/fix-ecosia-browser-r…

…egex fix: update ecosia browser regex to match multiple versioning structures
ua-parser · Jul 10, 2024 · 1458dfa · 1458dfa
2 parents df56280 + cc19966
commit 1458dfa
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/regexes.yaml b/regexes.yaml
@@ -487,9 +487,9 @@ user_agent_parsers:
     family_replacement: 'Tenta Browser'
 
   # Ecosia on iOS / Android
-  - regex: '(Ecosia) ios@(\d+)\.(\d+)\.(\d+)\.(\d+)'
+  - regex: '(Ecosia) ios@(\d+)(?:\.(\d+)|)(?:\.(\d+)|)(?:\.(\d+)|)'
     family_replacement: 'Ecosia iOS'
-  - regex: '(Ecosia) android@(\d+)\.(\d+)\.(\d+)\.(\d+)'
+  - regex: '(Ecosia) android@(\d+)(?:\.(\d+)|)(?:\.(\d+)|)(?:\.(\d+)|)'
     family_replacement: 'Ecosia Android'
 
   # Chrome Mobile

diff --git a/tests/test_ua.yaml b/tests/test_ua.yaml
@@ -8797,6 +8797,13 @@ test_cases:
     patch: '4951'
     patch_minor: '41'
 
+  - user_agent_string: 'Mozilla/5.0 (Linux; Android 10; K) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/119.0.0.0 Mobile Safari/537.36 (Ecosia android@119)'
+    family: 'Ecosia Android'
+    major: '119'
+    minor:
+    patch:
+    patch_minor:
+
   - user_agent_string: 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 MullvadBrowser/102.13.0'
     family: 'MullvadBrowser'
     major: '102'