Add signature-based onBehalf methods and natspec
#43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wildmolasses
force-pushed
the
behalfOf
branch
6 times, most recently
from
18fc9bb
to
2bbad9f
Compare
wildmolasses
force-pushed
the
behalfOf
branch
2 times, most recently
from
30978a5
to
399fbb6
Compare
wildmolasses
commented
Feb 7, 2024
apbendi
reviewed
Feb 7, 2024
There was a problem hiding this comment.
Hey @wildmolasses some comments after an initial pass through the contracts only. Looking forward to a walk through on the tests.
alexkeating
approved these changes
Feb 7, 2024
src/UniStaker.sol
Outdated
| totalDeposits[deposit.owner] += _amount; | ||
| earningPower[deposit.beneficiary] += _amount; | ||
| deposit.balance += _amount; | ||
| emit StakeDeposited(_depositId, _amount, deposit.balance); |
There was a problem hiding this comment.
Just a reminder that once this is rebased on main this should have the deposit.owner
wildmolasses
force-pushed
the
behalfOf
branch
2 times, most recently
from
42a386c
to
04259c7
Compare
|
Coverage after merging behalfOf into main will be
Coverage Report
|
|||||||||||||||||||||||||
wildmolasses
force-pushed
the
behalfOf
branch
from
04259c7
to
dfac7ee
Compare
apbendi
reviewed
Feb 8, 2024
There was a problem hiding this comment.
A couple small things @wildmolasses, but overall this looks great.
apbendi
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #29