Use concrete types with destroyCmd.Run() #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes this error: up: error: space.destroyCmd.Run(): couldn't find binding of type kubernetes.Interface for parameter 0 of func(kubernetes.Interface, install.Manager) error(), use kong.Bind(kubernetes.Interface)
Fixes this error: up: error: space.destroyCmd.Run(): couldn't find binding of type install.Manager for parameter 1 of func(*kubernetes.Clientset, install.Manager) error(), use kong.Bind(install.Manager)
avalanche123
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes these errors:
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR, as appropriate.How has this code been tested
I ran
up space destroyand verified that it got past the binding errors.