Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use concrete types with destroyCmd.Run() #365

Merged
merged 2 commits into from
Aug 23, 2023
Merged

Use concrete types with destroyCmd.Run() #365

merged 2 commits into from
Aug 23, 2023

Commits on Aug 23, 2023

  1. Make destroyCmd.Run() accept concrete clientset 

    Fixes this error:

up: error: space.destroyCmd.Run(): couldn't find binding of type kubernetes.Interface for parameter 0 of func(kubernetes.Interface, install.Manager) error(), use kong.Bind(kubernetes.Interface)
    @branden
    branden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    4e82a77 View commit details
    Browse the repository at this point in the history

  2. Make destroyCmd.Run() accept concrete installer 

    Fixes this error:

up: error: space.destroyCmd.Run(): couldn't find binding of type install.Manager for parameter 1 of func(*kubernetes.Clientset, install.Manager) error(), use kong.Bind(install.Manager)
    @branden
    branden committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    79ed4d9 View commit details
    Browse the repository at this point in the history