Skip to content

fix(otelsql): record error and status when SQL returns an error #158

fix(otelsql): record error and status when SQL returns an error

fix(otelsql): record error and status when SQL returns an error #158

Triggered via pull request December 10, 2023 19:15
@empireempire
synchronize #114
empire:patch-2
Status Failure
Total duration 22s
Artifacts

commitlint.yml

on: pull_request
commitlint
12s
commitlint
Fit to window
Zoom out
Zoom in

Annotations

1 error and 2 warnings
commitlint
You have commit messages with errors ⧗ input: Add tests ✖ subject may not be empty [subject-empty] ✖ type may not be empty [type-empty] ✖ found 2 problems, 0 warnings ⓘ Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint ⧗ input: Record error and status for Otelsql when SQL returns an error The Span ends early when SQL returns an error, which prevents Otelsql from recording the error and setting the status. This commit fixes this issue by deferring the Span.End() call. ✖ body's lines must not be longer than 100 characters [body-max-line-length] ✖ subject may not be empty [subject-empty] ✖ type may not be empty [type-empty] ✖ found 3 problems, 0 warnings ⓘ Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint
commitlint
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
commitlint
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/