fix(otelsql): record error and status when SQL returns an error #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vmihailenco , could you please take a look at this P.R. Thanks |
empire
changed the title
The Span ends early when SQL returns an error, which prevents Otelsql from recording the error. This commit fixes this issue by deferring the Span.End() call. Fixes: uptrace#115
|
@empire thanks for the fix. |
|
@vmihailenco Thanks for merging this pull request. When do you plan to release this fix? |
|
@empire v0.2.4 should be available withing few minutes. |
|
It sounds great. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Span ends early when SQL returns an error, which prevents Otelsql from recording the error.
This commit fixes this issue by deferring the Span.End() call.
Fixes: #115