Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(otelsql): record error and status when SQL returns an error #114

Merged
merged 2 commits into from
Mar 17, 2024
Merged

fix(otelsql): record error and status when SQL returns an error #114

merged 2 commits into from
Mar 17, 2024

Commits on Dec 10, 2023

  1. fix(otelsql): record error and status when SQL returns an error 

    The Span ends early when SQL returns an error, which prevents Otelsql from recording the error.
This commit fixes this issue by deferring the Span.End() call.

Fixes: uptrace#115
    @empire
    empire committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    1716db5 View commit details
    Browse the repository at this point in the history

Commits on Dec 23, 2023

  1. Merge branch 'uptrace:main' into patch-2

    @empire
    empire authored Dec 23, 2023
    Configuration menu
    Copy the full SHA
    caa310e View commit details
    Browse the repository at this point in the history