Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java: add JSON.DEL and JSON.FORGET #2490

Open
wants to merge 4 commits into
base: release-1.2
Choose a base branch
from
Open

Java: add JSON.DEL and JSON.FORGET #2490

wants to merge 4 commits into from
+396 −39

Conversation

jamesx-improving
Copy link
Collaborator

@jamesx-improving jamesx-improving commented Oct 21, 2024 •
edited
Loading

Issue link

This Pull Request is linked to issue (URL): #2430

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Commits will be squashed upon merging.

@jamesx-improving jamesx-improving requested a review from a team as a code owner October 21, 2024 22:10
jonathanl-bq
jonathanl-bq approved these changes Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@jonathanl-bq jonathanl-bq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix documentation and I'm okay with it.

java/client/src/main/java/glide/api/commands/servermodules/Json.java Outdated Show resolved Hide resolved
java/client/src/main/java/glide/api/commands/servermodules/Json.java Outdated Show resolved Hide resolved
java/client/src/main/java/glide/api/commands/servermodules/Json.java Outdated Show resolved Hide resolved
java/client/src/main/java/glide/api/commands/servermodules/Json.java Outdated Show resolved Hide resolved
java/client/src/main/java/glide/api/commands/servermodules/Json.java Outdated Show resolved Hide resolved
java/client/src/main/java/glide/api/commands/servermodules/Json.java Outdated Show resolved Hide resolved
tjzhang-BQ
tjzhang-BQ approved these changes Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@tjzhang-BQ tjzhang-BQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with the aforementioned doc fixes & test suggestion

yipin-chen
yipin-chen approved these changes Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@yipin-chen yipin-chen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: please address Yury's and Jonathan's comments. One CI test is red. Please check

@jamesx-improving jamesx-improving mentioned this pull request Oct 21, 2024
Open
22 tasks
@Yury-Fridlyand Yury-Fridlyand added the java issues and fixes related to the java client label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanl-bq jonathanl-bq jonathanl-bq approved these changes

@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand approved these changes

@tjzhang-BQ tjzhang-BQ tjzhang-BQ approved these changes

@yipin-chen yipin-chen yipin-chen approved these changes

Assignees
No one assigned
Labels
java issues and fixes related to the java client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jamesx-improving @jonathanl-bq @Yury-Fridlyand @tjzhang-BQ @yipin-chen