Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: upgrade vue to 2.7.x and removed dependency on @vue/composition-api #1077

Open
wants to merge 1 commit into
base: v1
Choose a base branch
from
Open

fix: upgrade vue to 2.7.x and removed dependency on @vue/composition-api #1077

wants to merge 1 commit into from

Conversation

kalebscholes
Copy link

With the release of Vue 2.7, which has Composition API built-in, the @vue/composition-api plugin is no longer needed.

@vinayakkulkarni
Copy link
Owner

Thanks for this @kalebscholes, i'll test this over the weekend.

@vinayakkulkarni vinayakkulkarni self-requested a review July 7, 2022 10:18
@vinayakkulkarni vinayakkulkarni self-assigned this Jul 7, 2022
@vinayakkulkarni vinayakkulkarni added enhancement New feature or request dependencies Pull requests that update a dependency file labels Jul 7, 2022
@kalebscholes
Copy link
Author

Hey @vinayakkulkarni, just wondering if you were able to test these changes?

@vinayakkulkarni
Copy link
Owner

Hey @vinayakkulkarni, just wondering if you were able to test these changes?

Screenshot 2022-08-01 at 1 11 10 AM

There are tons of changes by removing @vue/composition-api from the app, plus I require to test it as well requires multiple checks

@jrohland jrohland mentioned this pull request Nov 15, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinayakkulkarni vinayakkulkarni Awaiting requested review from vinayakkulkarni

At least 1 approving review is required to merge this pull request.

Assignees

@vinayakkulkarni vinayakkulkarni

Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kalebscholes @vinayakkulkarni