-
-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dealer of the Damned (Formerly-ish Six-Shot Sharper) #2331
Conversation
MASSIVE thanks to Kirie and the other devs who were there for the "Learn to Code" events on the LC13 discord for helping bring this to fruition. Genuinely never could have done this without you guys. |
Adds Dealer of the Damned and its associated E.G.O. DotD 1.1 Fixed some shit I forgot and made it so you can only get Death Dealer once per Ckey. DotD 1.2 Added the abormality record I forgot.
7c26423
to
80bad56
Compare
I'm willing to give this a test if it gets a new sprite. Talk to our spriters about it. |
Replaced sprites with those made by sponge_4781, as well as some minor tweaks.
Devsprites replaced, many thanks to sponge_4781 on the LC13 discord for making these beautiful sprites. |
362dba5
to
1635256
Compare
Adds Dealer of the Damned and its associated E.G.O. DotD 1.1 Fixed some shit I forgot and made it so you can only get Death Dealer once per Ckey. DotD 1.2 Added the abormality record I forgot.
Replaced sprites with those made by sponge_4781, as well as some minor tweaks.
157110f
to
c4f8986
Compare
Linter errors are a little fucky, just add some new lines at the end of everything. |
…omy-corp13 into Dealer-of-the-Damned
Accidentally made two Dealers with the last one, this is to fix it.
905ed84
to
acb472c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on the live server. People love it.
Merging.
* Dealer of the Damned V1 Adds Dealer of the Damned and its associated E.G.O. DotD 1.1 Fixed some shit I forgot and made it so you can only get Death Dealer once per Ckey. DotD 1.2 Added the abormality record I forgot. * Sprite Edits for DotD Replaced sprites with those made by sponge_4781, as well as some minor tweaks. * Dealer of the Damned V1 Adds Dealer of the Damned and its associated E.G.O. DotD 1.1 Fixed some shit I forgot and made it so you can only get Death Dealer once per Ckey. DotD 1.2 Added the abormality record I forgot. * Sprite Edits for DotD Replaced sprites with those made by sponge_4781, as well as some minor tweaks. * Update teth.dm * Rename Exactly what it says on the tin. Renames it from Dealer of the Damned to Six-Shot Sharper, because Coxswain thought the old name wasn't good enough to add in. Feel free to scrap this if Cox is a vocal minority on this issue. * Removes duplicate Accidentally made two Dealers with the last one, this is to fix it. --------- Co-authored-by: Kirie Saito <[email protected]>
* Dealer of the Damned V1 Adds Dealer of the Damned and its associated E.G.O. DotD 1.1 Fixed some shit I forgot and made it so you can only get Death Dealer once per Ckey. DotD 1.2 Added the abormality record I forgot. * Sprite Edits for DotD Replaced sprites with those made by sponge_4781, as well as some minor tweaks. * Dealer of the Damned V1 Adds Dealer of the Damned and its associated E.G.O. DotD 1.1 Fixed some shit I forgot and made it so you can only get Death Dealer once per Ckey. DotD 1.2 Added the abormality record I forgot. * Sprite Edits for DotD Replaced sprites with those made by sponge_4781, as well as some minor tweaks. * Update teth.dm * Rename Exactly what it says on the tin. Renames it from Dealer of the Damned to Six-Shot Sharper, because Coxswain thought the old name wasn't good enough to add in. Feel free to scrap this if Cox is a vocal minority on this issue. * Removes duplicate Accidentally made two Dealers with the last one, this is to fix it. --------- Co-authored-by: Kirie Saito <[email protected]>
* Dealer of the Damned V1 Adds Dealer of the Damned and its associated E.G.O. DotD 1.1 Fixed some shit I forgot and made it so you can only get Death Dealer once per Ckey. DotD 1.2 Added the abormality record I forgot. * Sprite Edits for DotD Replaced sprites with those made by sponge_4781, as well as some minor tweaks. * Dealer of the Damned V1 Adds Dealer of the Damned and its associated E.G.O. DotD 1.1 Fixed some shit I forgot and made it so you can only get Death Dealer once per Ckey. DotD 1.2 Added the abormality record I forgot. * Sprite Edits for DotD Replaced sprites with those made by sponge_4781, as well as some minor tweaks. * Update teth.dm * Rename Exactly what it says on the tin. Renames it from Dealer of the Damned to Six-Shot Sharper, because Coxswain thought the old name wasn't good enough to add in. Feel free to scrap this if Cox is a vocal minority on this issue. * Removes duplicate Accidentally made two Dealers with the last one, this is to fix it. --------- Co-authored-by: Kirie Saito <[email protected]>
About The Pull Request
This adds Six-Shot Sharper, a TETH abnormality, as well as its EGO, Luck of the Draw and its unique weapon, Death Dealer.
Why It's Good For The Game
The idea behind the abnormality has been considered by a decent chunk of players to be potentially fun to have, and it has been approved by the lead dev, Kitsunemitsu.
Changelog
🆑
imageadd: Added Six-Shot Sharper and its EGO's sprites, courtesy of sponge_4781 on the LC13 Discord
code: Added Six-Shot Sharper and its associated EGO (Luck of the Draw and Death Dealer)
🆑
Shit that needs to be done
NOTE: For all intents and purposes, the abnormality and its EGO are completely functional and able to be put into the game.
All that I'd like to change are some minor tweaks, such as making Death Dealer's sound when firing match the projectile it's using and re-adding a functional version of the dud round. Those can come later, though.