Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dealer of the Damned (Formerly-ish Six-Shot Sharper) #2331

Merged
merged 8 commits into from
Aug 18, 2024

Conversation

X3ros
Copy link
Contributor

@X3ros X3ros commented Jul 28, 2024

About The Pull Request

This adds Six-Shot Sharper, a TETH abnormality, as well as its EGO, Luck of the Draw and its unique weapon, Death Dealer.

Why It's Good For The Game

The idea behind the abnormality has been considered by a decent chunk of players to be potentially fun to have, and it has been approved by the lead dev, Kitsunemitsu.

Changelog

🆑
imageadd: Added Six-Shot Sharper and its EGO's sprites, courtesy of sponge_4781 on the LC13 Discord
code: Added Six-Shot Sharper and its associated EGO (Luck of the Draw and Death Dealer)
🆑

Shit that needs to be done

NOTE: For all intents and purposes, the abnormality and its EGO are completely functional and able to be put into the game.
All that I'd like to change are some minor tweaks, such as making Death Dealer's sound when firing match the projectile it's using and re-adding a functional version of the dud round. Those can come later, though.

@X3ros
Copy link
Contributor Author

X3ros commented Jul 28, 2024

MASSIVE thanks to Kirie and the other devs who were there for the "Learn to Code" events on the LC13 discord for helping bring this to fruition. Genuinely never could have done this without you guys.

Adds Dealer of the Damned and its associated E.G.O.

DotD 1.1

Fixed some shit I forgot and made it so you can only get Death Dealer once per Ckey.

DotD 1.2

Added the abormality record I forgot.
@X3ros X3ros force-pushed the Dealer-of-the-Damned branch from 7c26423 to 80bad56 Compare July 28, 2024 18:36
@InsightfulParasite InsightfulParasite added the Abnormality This is the abnormality label Jul 29, 2024
@Kitsunemitsu
Copy link
Contributor

I'm willing to give this a test if it gets a new sprite.

Talk to our spriters about it.

Replaced sprites with those made by sponge_4781, as well as some minor tweaks.
@X3ros
Copy link
Contributor Author

X3ros commented Aug 4, 2024

Devsprites replaced, many thanks to sponge_4781 on the LC13 discord for making these beautiful sprites.

@X3ros X3ros marked this pull request as ready for review August 4, 2024 20:29
@Kitsunemitsu Kitsunemitsu force-pushed the Dealer-of-the-Damned branch from 362dba5 to 1635256 Compare August 6, 2024 04:48
@X3ros X3ros changed the title Dealer of the Damned Six-Shot Sharper (Formerly Dealer of the Damned) Aug 8, 2024
X3ros and others added 3 commits August 16, 2024 12:32
Adds Dealer of the Damned and its associated E.G.O.

DotD 1.1

Fixed some shit I forgot and made it so you can only get Death Dealer once per Ckey.

DotD 1.2

Added the abormality record I forgot.
Replaced sprites with those made by sponge_4781, as well as some minor tweaks.
@Kitsunemitsu
Copy link
Contributor

Linter errors are a little fucky, just add some new lines at the end of everything.
I'm putting on TM.

X3ros added 3 commits August 16, 2024 13:22
Exactly what it says on the tin. Renames it from Dealer of the Damned to Six-Shot Sharper, because Coxswain thought the old name wasn't good enough to add in. Feel free to scrap this if Cox is a vocal minority on this issue.
Accidentally made two Dealers with the last one, this is to fix it.
@X3ros X3ros force-pushed the Dealer-of-the-Damned branch from 905ed84 to acb472c Compare August 18, 2024 16:36
@X3ros X3ros changed the title Six-Shot Sharper (Formerly Dealer of the Damned) Dealer of the Damned Aug 18, 2024
@X3ros X3ros changed the title Dealer of the Damned Dealer of the Damned (Formerly-ish Six-Shot Sharper) Aug 18, 2024
Copy link
Contributor

@Kitsunemitsu Kitsunemitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on the live server. People love it.
Merging.

@Kitsunemitsu Kitsunemitsu merged commit ed1e50f into vlggms:master Aug 18, 2024
10 checks passed
tile4 pushed a commit to tile4/lobotomy-corp13 that referenced this pull request Sep 11, 2024
* Dealer of the Damned V1

Adds Dealer of the Damned and its associated E.G.O.

DotD 1.1

Fixed some shit I forgot and made it so you can only get Death Dealer once per Ckey.

DotD 1.2

Added the abormality record I forgot.

* Sprite Edits for DotD

Replaced sprites with those made by sponge_4781, as well as some minor tweaks.

* Dealer of the Damned V1

Adds Dealer of the Damned and its associated E.G.O.

DotD 1.1

Fixed some shit I forgot and made it so you can only get Death Dealer once per Ckey.

DotD 1.2

Added the abormality record I forgot.

* Sprite Edits for DotD

Replaced sprites with those made by sponge_4781, as well as some minor tweaks.

* Update teth.dm

* Rename

Exactly what it says on the tin. Renames it from Dealer of the Damned to Six-Shot Sharper, because Coxswain thought the old name wasn't good enough to add in. Feel free to scrap this if Cox is a vocal minority on this issue.

* Removes duplicate

Accidentally made two Dealers with the last one, this is to fix it.

---------

Co-authored-by: Kirie Saito <[email protected]>
tile4 pushed a commit to tile4/lobotomy-corp13 that referenced this pull request Sep 11, 2024
* Dealer of the Damned V1

Adds Dealer of the Damned and its associated E.G.O.

DotD 1.1

Fixed some shit I forgot and made it so you can only get Death Dealer once per Ckey.

DotD 1.2

Added the abormality record I forgot.

* Sprite Edits for DotD

Replaced sprites with those made by sponge_4781, as well as some minor tweaks.

* Dealer of the Damned V1

Adds Dealer of the Damned and its associated E.G.O.

DotD 1.1

Fixed some shit I forgot and made it so you can only get Death Dealer once per Ckey.

DotD 1.2

Added the abormality record I forgot.

* Sprite Edits for DotD

Replaced sprites with those made by sponge_4781, as well as some minor tweaks.

* Update teth.dm

* Rename

Exactly what it says on the tin. Renames it from Dealer of the Damned to Six-Shot Sharper, because Coxswain thought the old name wasn't good enough to add in. Feel free to scrap this if Cox is a vocal minority on this issue.

* Removes duplicate

Accidentally made two Dealers with the last one, this is to fix it.

---------

Co-authored-by: Kirie Saito <[email protected]>
tile4 pushed a commit to tile4/lobotomy-corp13 that referenced this pull request Oct 1, 2024
* Dealer of the Damned V1

Adds Dealer of the Damned and its associated E.G.O.

DotD 1.1

Fixed some shit I forgot and made it so you can only get Death Dealer once per Ckey.

DotD 1.2

Added the abormality record I forgot.

* Sprite Edits for DotD

Replaced sprites with those made by sponge_4781, as well as some minor tweaks.

* Dealer of the Damned V1

Adds Dealer of the Damned and its associated E.G.O.

DotD 1.1

Fixed some shit I forgot and made it so you can only get Death Dealer once per Ckey.

DotD 1.2

Added the abormality record I forgot.

* Sprite Edits for DotD

Replaced sprites with those made by sponge_4781, as well as some minor tweaks.

* Update teth.dm

* Rename

Exactly what it says on the tin. Renames it from Dealer of the Damned to Six-Shot Sharper, because Coxswain thought the old name wasn't good enough to add in. Feel free to scrap this if Cox is a vocal minority on this issue.

* Removes duplicate

Accidentally made two Dealers with the last one, this is to fix it.

---------

Co-authored-by: Kirie Saito <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Abnormality This is the abnormality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants