Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes Some Abnormalities Not Bleed[DONE] #2336

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

InsightfulParasite
Copy link
Collaborator

@InsightfulParasite InsightfulParasite commented Jul 30, 2024

About The Pull Request

Makes some abnormalities not bleed or produce meaty gibs when they are not meat based organisms.

/mob/living/simple_animal/hostile/abnormality/proc/spawn_gibs()
if(blood_volume <= 0)
return
return new /obj/effect/gibspawner/generic(drop_location(), src, get_static_viruses())

  • Ardor Blossom Moth
  • Funderal
  • Helper
  • Snow Queen
  • Steam Transport Machine
  • MHz
  • Book Without Pictures or Dialogue
  • Faelantern
  • So That No One Will Cry
  • Dimensional Refraction Varient
  • Ebony Queen
  • Snow Whites Apple
  • Quiet Day

Why It's Good For The Game

Just a personal immersion thing since a ice monster exploding into blood and gibs is a bit strange.

Changelog

🆑
tweak: Removes bleeding and organic gibs from inorganic abnormalities.
/:cl:

@InsightfulParasite InsightfulParasite added the Tweak A small change/addition to already existing systems. label Jul 30, 2024
@InsightfulParasite InsightfulParasite force-pushed the less-blood branch 2 times, most recently from b236997 to 9b7dd77 Compare July 30, 2024 02:34
@InsightfulParasite InsightfulParasite changed the title Makes Some Abnormalities Not Bleed Makes Some Abnormalities Not Bleed[DONE] Jul 30, 2024
@InsightfulParasite InsightfulParasite force-pushed the less-blood branch 2 times, most recently from ef21d88 to 5540a84 Compare August 6, 2024 04:16
@InsightfulParasite InsightfulParasite force-pushed the less-blood branch 2 times, most recently from bfdcdf3 to 3d8284e Compare August 6, 2024 22:38
@Coxswain-Navigator
Copy link
Contributor

I have mixed feelings on this. I know that PM likes to throw us a curveball with designs like MFE where it's a stone statue but when you break it open there's blood and guts inside and it bleeds everywhere. If I'm not mistaken, even the break-offs for so that no one will cry show a bunch of bloody meat inside. I think this is probably fine for a few of them - namely, the plant based ones and the robots. Not sure how I feel about snow queen, either. For now I would suggest removing this feature from STNWC and if its possible maybe you could make the paper mobs spawned by book inherit that same feature.

@InsightfulParasite
Copy link
Collaborator Author

I have mixed feelings on this. I know that PM likes to throw us a curveball with designs like MFE where it's a stone statue but when you break it open there's blood and guts inside and it bleeds everywhere. If I'm not mistaken, even the break-offs for so that no one will cry show a bunch of bloody meat inside. I think this is probably fine for a few of them - namely, the plant based ones and the robots. Not sure how I feel about snow queen, either. For now I would suggest removing this feature from STNWC and if its possible maybe you could make the paper mobs spawned by book inherit that same feature.

I can do that.

@InsightfulParasite InsightfulParasite changed the title Makes Some Abnormalities Not Bleed[DONE] Makes Some Abnormalities Not Bleed[WIP] Aug 9, 2024
@InsightfulParasite InsightfulParasite changed the title Makes Some Abnormalities Not Bleed[WIP] Makes Some Abnormalities Not Bleed[DONE] Aug 9, 2024
@InsightfulParasite
Copy link
Collaborator Author

Okay so follow up on the paper thing. Gibspawns are defined by a proc so i cant make all the paper things not explode into gore. I can stop them bleeding... unless they have personalized code that makes them die when they have no blood.

Kitsunemitsu

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tweak A small change/addition to already existing systems.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants