Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add facts for Debian 12 #283

Merged
merged 2 commits into from
Aug 17, 2023
Merged

Add facts for Debian 12 #283

merged 2 commits into from
Aug 17, 2023

Conversation

TheMeier
Copy link
Contributor

@TheMeier TheMeier commented Aug 2, 2023

fixes #279

Copy link
Member

@kenyon kenyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we also update the coverage table in the README?

@TheMeier
Copy link
Contributor Author

TheMeier commented Aug 3, 2023

Shall we also update the coverage table in the README?

Done

Copy link
Member

@kenyon kenyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I don't know how acceptable it is to be not using puppetlabs packages.

@TheMeier
Copy link
Contributor Author

TheMeier commented Aug 3, 2023

well we were asking for some time
https://puppetcommunity.slack.com/archives/C0W298S9G/p1688463627666479
https://app.slack.com/client/T0AQJ2CTU/C0W298S9G/thread/C0W298S9G-1688463627.666479
https://puppetcommunity.slack.com/archives/C0W298S9G/p1690547752195069
https://puppet.atlassian.net/jira/software/c/projects/PA/issues/PA-4995

instead of buliding processes for the well known regular os update cycles puppetlabs seems to have opted for a reactionary process, catering to the paying enterprise customers:

I checked in with the teams and no this is not currently on the road map or prioritized.
If we can get details of who requires this we can make a case if there is a big enough requirement

There has to be enough usage from the community for us to commit the resources. Unfortunately, what we see is that something like 85+% of our deployments are on RHEL and Ubuntu, with Debian being a very small percentage.

i would appreciate if voxpupuli could take the open source/agile approach and go ahead with this change, and revert the workarounds once the puppetlabs repos/packages drop. i do volunteer to provide a MR then

@TheMeier
Copy link
Contributor Author

TheMeier commented Aug 7, 2023

any updates here?

@bastelfreak
Copy link
Member

I think for a start this is fine. We can regenerate them when puppet decides to support modern operating systems.

@bastelfreak bastelfreak merged commit 26a2beb into voxpupuli:master Aug 17, 2023
6 checks passed
@bastelfreak bastelfreak changed the title feat: add facts for debian-12 Add facts for debian-12 Aug 17, 2023
@bastelfreak bastelfreak changed the title Add facts for debian-12 Add facts for Debian 12 Aug 17, 2023
@TheMeier TheMeier deleted the issue/279 branch September 4, 2023 09:35
@TheMeier
Copy link
Contributor Author

TheMeier commented Sep 4, 2023

@bastelfreak thanks for merging, any change for a new release soon?

@kajinamit
Copy link

@bastelfreak sorry for duplicate ping but I'm wondering if we can have a new release with this change, so that we can enable unit tests with Debian 12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debian 12 support
4 participants