Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove proof options from base proof serialization again. #179

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

aljones15
Copy link
Contributor

@aljones15 aljones15 commented Jul 2, 2024

Corrects a potential regress of https://github.com/w3c/vc-di-bbs/pull/173/files

Removes the proofOptions section from base proof serialization again.
Interestingly the proofOptions did not need to be removed from the Algorithms section again.


Preview | Diff

@aljones15 aljones15 marked this pull request as ready for review July 2, 2024 14:20
@aljones15 aljones15 mentioned this pull request Jul 2, 2024
@msporny
Copy link
Member

msporny commented Jul 15, 2024

Editorial (removing previously removed text again), multiple positive reviews, no changes requested, no objections, merging.

@msporny msporny merged commit c7d5955 into w3c:main Jul 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants