Fix compatibility with eslint v9 #799
Open
+73
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkuykendall
force-pushed
the
master
branch
6 times, most recently
from
6e2b4da
to
a69ed3b
Compare
rkuykendall
force-pushed
the
master
branch
5 times, most recently
from
e1ffb4a
to
2c54479
Compare
kahagerman
reviewed
Jun 21, 2024
| }, | ||
| ); | ||
| const { stdout: version } = run(`${commandPrefix} eslint -v`, { dir }); | ||
| const isV9 = version.startsWith("v9."); |
There was a problem hiding this comment.
This appears to also be required for eslint version 8.x.y as well.
It would be better to parse out the major version ^v(\d+)\.\d+.\d+, and check it it's >= 8.
|
Thank you for your contribution to this project! This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--extfor eslint v9