Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(platforms): confusing error message when unable to load platform #6176

Merged
merged 7 commits into from
Apr 23, 2024

Conversation

hasanaburayyan
Copy link
Contributor

@hasanaburayyan hasanaburayyan commented Apr 8, 2024

Closes: #6147

Checklist

  • Title matches Winglang's style guide
  • Description explains motivation and solution
  • Tests added (always)
  • Docs updated (only required for features)
  • Added pr/e2e-full label if this feature requires end-to-end testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

@hasanaburayyan hasanaburayyan requested a review from a team as a code owner April 8, 2024 18:42
Copy link

github-actions bot commented Apr 8, 2024

Thanks for opening this pull request! 🎉
Please consult the contributing guidelines for details on how to contribute to this project.
If you need any assistence, don't hesitate to ping the relevant owner over Slack.

Topic Owner
Wing SDK and utility APIs @chriscbr
Wing Console @ainvoner, @skyrpex, @polamoros
JSON, structs, primitives and collections @hasanaburayyan
Platforms and plugins @hasanaburayyan
Frontend resources (website, react, etc) @tsuf239
Language design @chriscbr
VSCode extension and language server @markmcculloh
Compiler architecture, inflights, lifting @yoav-steinberg
Wing Testing Framework @tsuf239
Wing CLI @markmcculloh
Build system, dev environment, releases @markmcculloh
Library Ecosystem @chriscbr
Documentation @hasanaburayyan
SDK test suite @tsuf239
Examples @hasanaburayyan
Wing Playground @eladcon

@monadabot
Copy link
Contributor

monadabot commented Apr 8, 2024

Console preview environment is available at https://wing-console-pr-6176.fly.dev 🚀

Last Updated (UTC) 2024-04-18 12:07

@monadabot
Copy link
Contributor

monadabot commented Apr 8, 2024

Benchmarks

Comparison to Baseline ⬜⬜⬜⬜⬜⬜⬜⬜🟥⬜⬜⬜⬜
Benchmark Before After Change
version 59ms±1.37 59ms±0.62 0ms (-0.17%)⬜
functions_1.test.w -t sim 398ms±11.78 391ms±4.79 -7ms (-1.67%)⬜
functions_1.test.w -t tf-aws 808ms±5.13 813ms±3.99 +5ms (+0.65%)⬜
jsii_big.test.w -t sim 2760ms±16.41 2782ms±12.81 +21ms (+0.77%)⬜
jsii_big.test.w -t tf-aws 2986ms±7.9 2989ms±13.26 +2ms (+0.08%)⬜
functions_10.test.w -t sim 484ms±9.32 487ms±5.59 +3ms (+0.6%)⬜
functions_10.test.w -t tf-aws 1992ms±9.5 1999ms±12.83 +7ms (+0.37%)⬜
jsii_small.test.w -t sim 361ms±4.15 367ms±3.24 +6ms (+1.6%)⬜
jsii_small.test.w -t tf-aws 596ms±2.58 605ms±3.32 +9ms (+1.56%)🟥
empty.test.w -t sim 355ms±3.68 357ms±6.13 +2ms (+0.5%)⬜
empty.test.w -t tf-aws 580ms±3.04 591ms±5.14 +10ms (+1.79%)⬜
hello_world.test.w -t sim 392ms±3.35 391ms±3.45 -1ms (-0.13%)⬜
hello_world.test.w -t tf-aws 1498ms±8.33 1501ms±6.37 +4ms (+0.25%)⬜

⬜ Within 1.5 standard deviations
🟩 Faster, Above 1.5 standard deviations
🟥 Slower, Above 1.5 standard deviations

Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI.

Results
name mean min max moe sd
version 59ms 58ms 60ms 1ms 1ms
functions_1.test.w -t sim 391ms 384ms 406ms 5ms 7ms
functions_1.test.w -t tf-aws 813ms 808ms 825ms 4ms 6ms
jsii_big.test.w -t sim 2782ms 2749ms 2813ms 13ms 18ms
jsii_big.test.w -t tf-aws 2989ms 2966ms 3027ms 13ms 19ms
functions_10.test.w -t sim 487ms 480ms 504ms 6ms 8ms
functions_10.test.w -t tf-aws 1999ms 1968ms 2027ms 13ms 18ms
jsii_small.test.w -t sim 367ms 360ms 375ms 3ms 5ms
jsii_small.test.w -t tf-aws 605ms 596ms 613ms 3ms 5ms
empty.test.w -t sim 357ms 341ms 367ms 6ms 9ms
empty.test.w -t tf-aws 591ms 580ms 600ms 5ms 7ms
hello_world.test.w -t sim 391ms 384ms 399ms 3ms 5ms
hello_world.test.w -t tf-aws 1501ms 1486ms 1511ms 6ms 9ms
Last Updated (UTC) 2024-04-18 12:12

@monadabot monadabot added the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Apr 8, 2024
@MarkMcCulloh MarkMcCulloh removed the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Apr 9, 2024
Copy link
Contributor

mergify bot commented Apr 23, 2024

Thanks for contributing, @hasanaburayyan! This PR will now be added to the merge queue, or immediately merged if hasan/platform-tidy is up-to-date with main and the queue is empty.

mergify bot added a commit that referenced this pull request Apr 23, 2024
@mergify mergify bot merged commit ddabbd9 into main Apr 23, 2024
15 checks passed
@mergify mergify bot deleted the hasan/platform-tidy branch April 23, 2024 16:50
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.72.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Very confusing error message when platform cannot be found
4 participants