Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli)!: wing secrets #6235

Merged
merged 33 commits into from
Apr 23, 2024
Merged

feat(cli)!: wing secrets #6235

merged 33 commits into from
Apr 23, 2024

Conversation

hasanaburayyan
Copy link
Contributor

@hasanaburayyan hasanaburayyan commented Apr 14, 2024

Breaking Change

  • cloud.Secret for sim no longer uses a ~/.wing/secrets.json file, instead now secrets are expected on a per repo basis in a .env file

New Features

  • wing secrets command allows storing secrets interactively based on target. Currently supported on:
    • tf-aws
    • sim
  • wing secrets --list returns a list of all the required secrets for your application

Misc

  • Some refactoring to platform-manager, mainly extracting hook collection into its own function

Checklist

  • Title matches Winglang's style guide
  • Description explains motivation and solution
  • Tests added (always)
  • Docs updated (only required for features)
  • Added pr/e2e-full label if this feature requires end-to-end testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

Copy link

Thanks for opening this pull request! 🎉
Please consult the contributing guidelines for details on how to contribute to this project.
If you need any assistence, don't hesitate to ping the relevant owner over Slack.

Topic Owner
Wing SDK and utility APIs @chriscbr
Wing Console @ainvoner, @skyrpex, @polamoros
JSON, structs, primitives and collections @hasanaburayyan
Platforms and plugins @hasanaburayyan
Frontend resources (website, react, etc) @tsuf239
Language design @chriscbr
VSCode extension and language server @markmcculloh
Compiler architecture, inflights, lifting @yoav-steinberg
Wing Testing Framework @tsuf239
Wing CLI @markmcculloh
Build system, dev environment, releases @markmcculloh
Library Ecosystem @chriscbr
Documentation @hasanaburayyan
SDK test suite @tsuf239
Examples @hasanaburayyan
Wing Playground @eladcon

@monadabot
Copy link
Contributor

monadabot commented Apr 17, 2024

Console preview environment is available at https://wing-console-pr-6235.fly.dev 🚀

Last Updated (UTC) 2024-04-23 15:17

@monadabot
Copy link
Contributor

monadabot commented Apr 17, 2024

Benchmarks

Comparison to Baseline ⬜⬜🟥⬜⬜⬜⬜⬜🟥⬜⬜⬜🟥
Benchmark Before After Change
version 57ms±0.47 59ms±0.99 +2ms (+3.14%)⬜
functions_1.test.w -t sim 391ms±4.59 398ms±3.54 +7ms (+1.69%)⬜
functions_1.test.w -t tf-aws 808ms±3.91 817ms±4.18 +9ms (+1.17%)🟥
jsii_big.test.w -t sim 2779ms±12.87 2796ms±22.04 +17ms (+0.61%)⬜
jsii_big.test.w -t tf-aws 2985ms±9.86 2992ms±9.63 +7ms (+0.23%)⬜
functions_10.test.w -t sim 484ms±7.1 489ms±13.16 +4ms (+0.92%)⬜
functions_10.test.w -t tf-aws 1991ms±9.51 2012ms±10.59 +21ms (+1.04%)⬜
jsii_small.test.w -t sim 363ms±3.67 368ms±2.67 +5ms (+1.45%)⬜
jsii_small.test.w -t tf-aws 595ms±3.53 604ms±1.98 +9ms (+1.54%)🟥
empty.test.w -t sim 356ms±2.91 361ms±5.37 +5ms (+1.45%)⬜
empty.test.w -t tf-aws 587ms±5.05 590ms±3.51 +3ms (+0.5%)⬜
hello_world.test.w -t sim 391ms±4.18 395ms±3.68 +4ms (+1.04%)⬜
hello_world.test.w -t tf-aws 1495ms±5.04 1507ms±3.52 +11ms (+0.76%)🟥

⬜ Within 1.5 standard deviations
🟩 Faster, Above 1.5 standard deviations
🟥 Slower, Above 1.5 standard deviations

Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI.

Results
name mean min max moe sd
version 59ms 58ms 63ms 1ms 1ms
functions_1.test.w -t sim 398ms 389ms 407ms 4ms 5ms
functions_1.test.w -t tf-aws 817ms 810ms 828ms 4ms 6ms
jsii_big.test.w -t sim 2796ms 2768ms 2856ms 22ms 31ms
jsii_big.test.w -t tf-aws 2992ms 2973ms 3008ms 10ms 13ms
functions_10.test.w -t sim 489ms 458ms 514ms 13ms 18ms
functions_10.test.w -t tf-aws 2012ms 1993ms 2039ms 11ms 15ms
jsii_small.test.w -t sim 368ms 363ms 375ms 3ms 4ms
jsii_small.test.w -t tf-aws 604ms 600ms 608ms 2ms 3ms
empty.test.w -t sim 361ms 352ms 376ms 5ms 8ms
empty.test.w -t tf-aws 590ms 580ms 596ms 4ms 5ms
hello_world.test.w -t sim 395ms 389ms 406ms 4ms 5ms
hello_world.test.w -t tf-aws 1507ms 1501ms 1517ms 4ms 5ms
Last Updated (UTC) 2024-04-23 15:23

@monadabot monadabot added the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Apr 17, 2024
@hasanaburayyan hasanaburayyan added 🚧 pr/do-not-merge PRs with this label will not be automatically merged by mergify. and removed ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! labels Apr 17, 2024
@hasanaburayyan hasanaburayyan marked this pull request as ready for review April 17, 2024 21:21
@hasanaburayyan hasanaburayyan requested review from eladb, MarkMcCulloh and a team April 19, 2024 16:16
@MarkMcCulloh MarkMcCulloh changed the title feat(cli): wing secrets feat(cli)!: wing secrets Apr 19, 2024
@monadabot monadabot added the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Apr 22, 2024
@hasanaburayyan hasanaburayyan removed the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Apr 23, 2024
Copy link
Contributor

mergify bot commented Apr 23, 2024

Thanks for contributing, @hasanaburayyan! This PR will now be added to the merge queue, or immediately merged if hasan/create-secrets is up-to-date with main and the queue is empty.

mergify bot added a commit that referenced this pull request Apr 23, 2024
@hasanaburayyan
Copy link
Contributor Author

@mergify refresh

Copy link
Contributor

mergify bot commented Apr 23, 2024

refresh

✅ Pull request refreshed

mergify bot added a commit that referenced this pull request Apr 23, 2024
Copy link
Contributor

mergify bot commented Apr 23, 2024

Thanks for contributing, @hasanaburayyan! This PR will now be added to the merge queue, or immediately merged if hasan/create-secrets is up-to-date with main and the queue is empty.

@mergify mergify bot merged commit 9a61a4c into main Apr 23, 2024
25 checks passed
@mergify mergify bot deleted the hasan/create-secrets branch April 23, 2024 15:31
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.72.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants