Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge queue: embarking main (fa4a7a5) and #6235 together #6302

Closed
wants to merge 33 commits into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Apr 23, 2024

✨ Pull request #6235 which was ahead in the queue has been dequeued. ✨

Branch main (fa4a7a5) and #6235 are embarked together for merge.

This pull request has been created by Mergify to speculatively check the mergeability of #6235.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue default for merge:

Required conditions to stay in the queue:

---
previous_failed_batches: []
pull_requests:
  - number: 6235
...

@mergify mergify bot closed this Apr 23, 2024
@mergify mergify bot deleted the mergify/merge-queue/37918b454f branch April 23, 2024 15:14
@monadabot
Copy link
Contributor

Benchmarks

Comparison to Baseline ⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜
Benchmark Before After Change
version 59ms±0.58 60ms±0.61 +1ms (+1.95%)⬜
functions_1.test.w -t sim 398ms±6.01 400ms±4.89 +3ms (+0.69%)⬜
functions_1.test.w -t tf-aws 820ms±4.18 825ms±9.54 +5ms (+0.62%)⬜
jsii_big.test.w -t sim 2803ms±15.1 2811ms±15.26 +9ms (+0.32%)⬜
jsii_big.test.w -t tf-aws 2995ms±19.36 3024ms±13.24 +28ms (+0.95%)⬜
functions_10.test.w -t sim 491ms±14.73 497ms±6.08 +6ms (+1.26%)⬜
functions_10.test.w -t tf-aws 2017ms±12.13 2036ms±13.21 +19ms (+0.93%)⬜
jsii_small.test.w -t sim 367ms±5.35 375ms±4.39 +7ms (+1.98%)⬜
jsii_small.test.w -t tf-aws 606ms±3.3 612ms±6.25 +6ms (+0.97%)⬜
empty.test.w -t sim 369ms±4.51 365ms±5.63 -4ms (-1.11%)⬜
empty.test.w -t tf-aws 596ms±5.76 605ms±4.19 +9ms (+1.43%)⬜
hello_world.test.w -t sim 398ms±6.07 406ms±6.19 +9ms (+2.18%)⬜
hello_world.test.w -t tf-aws 1514ms±11.32 1521ms±6.68 +7ms (+0.46%)⬜

⬜ Within 1.5 standard deviations
🟩 Faster, Above 1.5 standard deviations
🟥 Slower, Above 1.5 standard deviations

Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI.

Results
name mean min max moe sd
version 60ms 59ms 61ms 1ms 1ms
functions_1.test.w -t sim 400ms 387ms 409ms 5ms 7ms
functions_1.test.w -t tf-aws 825ms 809ms 843ms 10ms 13ms
jsii_big.test.w -t sim 2811ms 2780ms 2852ms 15ms 21ms
jsii_big.test.w -t tf-aws 3024ms 2996ms 3051ms 13ms 19ms
functions_10.test.w -t sim 497ms 485ms 510ms 6ms 8ms
functions_10.test.w -t tf-aws 2036ms 1995ms 2059ms 13ms 18ms
jsii_small.test.w -t sim 375ms 362ms 384ms 4ms 6ms
jsii_small.test.w -t tf-aws 612ms 600ms 633ms 6ms 9ms
empty.test.w -t sim 365ms 348ms 374ms 6ms 8ms
empty.test.w -t tf-aws 605ms 593ms 612ms 4ms 6ms
hello_world.test.w -t sim 406ms 392ms 418ms 6ms 9ms
hello_world.test.w -t tf-aws 1521ms 1512ms 1536ms 7ms 9ms
Last Updated (UTC) 2024-04-23 15:21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants