[GUI] Indicate wallet is syncing after completing installer #1370
Conversation
The `amount` function can call `amount_with_size` rather than repeating the underlying call to `render_amount`.
|
Here's how it looks when importing a descriptor: |
The wallet's height is taken from the cache and is used to check if the wallet has been initially synced after creation. For the remote backend, the cache refresh should be done with the usual frequency while the wallet's height is 0 so that the sync completion can be detected sooner.
jp1ac4
force-pushed
the
gui-check-wallet-height
branch
from
24d2075
to
6f4eb79
Compare
|
I've made the following changes:
|
|
Note: while importing descriptor with a bitcoin core, the synced state is still empty which is normal because user has to trigger a rescan but it may be confusing as the "syncing" implies that the wallet is updating to a correct state. |
|
That's a good point, and bad UX from our import descriptor flow. I suppose the user should ask for the rescan at import time, before going to the wallet. |
|
As per what was discussed offline:
This should be a valid option since in the cases in which wallet height is 0 we don't expect any update from the first poll. |
This is to resolve #1361.
The home page considers the wallet to be syncing if its height is 0. In this case, the balance will slowly blink and a "Syncing..." text will appear just below.
The home page will check the wallet's height upon each cache refresh, and will reload the home page once the syncing has completed so that the updated balance is displayed without the user needing to do anything.
Both the blinking balance and "Syncing..." text use a new
Carouselwidget that cycles through different child widgets at a specified rate.EDIT: I've added an extra commit to address #1363 as that is also related to the wallet height and cache refresh.