Port to ROS 2 #209
Port to ROS 2 #209
Conversation
Followed migration instructions in https://index.ros.org/doc/ros2/Contributing/Migration-Guide/
This prevents dependent libraries from failing with something like: serial.lib(list_ports_win.obj) : error LNK2019: unresolved external symbol __imp_SetupDiEnumDeviceInfo referenced in
|
CI is failing because it's trying to run ament, not colcon. I recommend just turning off CI for this branch. |
|
Here is an alternative change that is less invasive and includes tests: cottsay@f6bd881. You should consider pulling some of the goodness from that change into your proposal. I'd also like to propose that this package be introduced into ROS 2 as a pure CMake package instead of ament. It has no ROS dependencies, and is useful outside of ROS. Change to a pure CMake package: cottsay@4d5be00 Note that the pure CMake package and the Ament package are consumed in slightly different ways, so if the package were to be released as pure CMake, any current consumers of the Ament fork would likely need to be updated. |
|
Any chance this can get merged and a release can be done for Humble? |
|
tonybaltovski commented 22 minutes ago Oh wow you ran into this today too 😆 @wjwwood we've been using a branch for ROS 2 located here: |
|
Yup! Thanks for that. We are looking into porting some drivers that depend on it: Thus, a release would be needed to bloom them as packages. |
cherry-picking commit 4d5be00 from @cottsay See: wjwwood#209 (comment) Author: Scott K Logan <[email protected]> Date: Wed Jul 3 13:24:15 2019 -0700 Conflicts: CMakeLists.txt package.xml tests/CMakeLists.txt Signed-off-by: Alex Moriarty <[email protected]>
cherry-picking commit 4d5be00 from @cottsay See: wjwwood/serial#209 (comment) Author: Scott K Logan <[email protected]> Date: Wed Jul 3 13:24:15 2019 -0700 Conflicts: CMakeLists.txt package.xml tests/CMakeLists.txt Signed-off-by: Alex Moriarty <[email protected]>
cherry-picking commit 4d5be00 from @cottsay See: wjwwood/serial#209 (comment) Author: Scott K Logan <[email protected]> Date: Wed Jul 3 13:24:15 2019 -0700 Conflicts: CMakeLists.txt package.xml tests/CMakeLists.txt Signed-off-by: Alex Moriarty <[email protected]>
fixes #204