Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C24_WMDE_Desktop_DE_06 #555

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

C24_WMDE_Desktop_DE_06 #555

wants to merge 3 commits into from

Conversation

moiikana
Copy link
Contributor

@moiikana moiikana force-pushed the C24_WMDE_Desktop_DE_06 branch 6 times, most recently from a92748e to 62871d3 Compare September 30, 2024 09:53
@moiikana moiikana marked this pull request as ready for review September 30, 2024 11:15
Abban
Abban approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@Abban Abban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very good work. We'll have a chat with the PM about what to do on smaller sizes, and I've pinged him that the colour contrast is too low.

src/components/Footer/SmallPrintFooter.vue Show resolved Hide resolved
src/themes/Svingle/Footer/SmallPrintFooter.scss Outdated Show resolved Hide resolved
@moiikana moiikana force-pushed the C24_WMDE_Desktop_DE_06 branch 7 times, most recently from be78f86 to b455b24 Compare October 2, 2024 08:32
@moiikana
Copy link
Contributor Author

moiikana commented Oct 2, 2024

added a function that adds tracking to the FAQ link since last review

@moiikana moiikana requested a review from Abban October 2, 2024 16:24
@Abban Abban force-pushed the C24_WMDE_Desktop_DE_06 branch 2 times, most recently from 391e93d to b16fc10 Compare October 16, 2024 05:12
@moiikana @Abban
Implement VAR for C24_WMDE_Desktop_DE_06
ca50886 
- new footer (SmallPrintFooter) component that has it's own colors+layout
- fix chevron color being too dark (->white again)
- add title attributes to links with explanations

https://phabricator.wikimedia.org/T375599
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sperling-0 Sperling-0 Sperling-0 approved these changes

@gbirke gbirke Awaiting requested review from gbirke

@Abban Abban Awaiting requested review from Abban

Assignees
No one assigned
Labels
Approved Currently Live
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@moiikana @Abban @Sperling-0