Remove broadcast 'upgrade' support #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chomp's "smart" routing feature allows a prefix to opt-in to having its messages yeeted out across group chats if the destination target for a whisper is in your group. This is strictly an optimistic upgrade and not a guarantee on comms routing. With the advent of per-prefix throttles and the difference between behavior for whispers vs. group channels, this ends up being a trap that can ultimately slow such comms down to a crawl. For now let's kill off this support from the perspective of senders entirely and revisit if it's desirable later. Chomp can still receive messages with the broadcast bit set and process them accordingly, but going forward it won't send them out.
|
i am the alpha here |
|
wtf |
|
flex |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chomp's "smart" routing feature allows a prefix to opt-in to having its messages yeeted out across group chats if the destination target for a whisper is in your group. This is strictly an optimistic upgrade and not a guarantee on comms routing.
With the advent of per-prefix throttles and the difference between behavior for whispers vs. group channels, this ends up being a trap that can ultimately slow such comms down to a crawl.
For now let's kill off this support from the perspective of senders entirely and revisit if it's desirable later. Chomp can still receive messages with the broadcast bit set and process them accordingly, but going forward it won't send them out.