Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove broadcast 'upgrade' support #58

Merged
merged 1 commit into from
May 7, 2024

Commits on May 7, 2024

  1. Remove broadcast 'upgrade' support

    Chomp's "smart" routing feature allows a prefix to opt-in to having its
    messages yeeted out across group chats if the destination target for a
    whisper is in your group. This is strictly an optimistic upgrade and not
    a guarantee on comms routing.
    
    With the advent of per-prefix throttles and the difference between
    behavior for whispers vs. group channels, this ends up being a trap that
    can ultimately slow such comms down to a crawl.
    
    For now let's kill off this support from the perspective of senders
    entirely and revisit if it's desirable later. Chomp can still receive
    messages with the broadcast bit set and process them accordingly, but
    going forward it won't send them out.
    Meorawr committed May 7, 2024
    Configuration menu
    Copy the full SHA
    3efd135 View commit details
    Browse the repository at this point in the history