Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: protocol client #2

Merged
merged 2 commits into from
Dec 4, 2023
Merged

feat: protocol client #2

merged 2 commits into from
Dec 4, 2023

Conversation

LingKa28
Copy link
Contributor

@LingKa28 LingKa28 commented Sep 27, 2023 •
edited
Loading

Base: #1

Please briefly answer these questions:

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
    Add new feature.
  • what changes does this pull request make?
    • add format & lint & test ci
    • add kv clinet & tests
  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)
    No.

@LingKa28 LingKa28 marked this pull request as draft September 27, 2023 11:22
@LingKa28 LingKa28 marked this pull request as ready for review September 28, 2023 06:22
@codecov
Copy link

codecov bot commented Sep 28, 2023

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

@LingKa28 LingKa28 force-pushed the feature/protocol-client branch 2 times, most recently from cacbe79 to c705923 Compare October 5, 2023 05:44
@LingKa28 LingKa28 mentioned this pull request Oct 5, 2023
Closed
@mergify mergify bot mentioned this pull request Nov 9, 2023
Merged
Phoenix500526
Phoenix500526 reviewed Nov 10, 2023
View reviewed changes
.github/workflows/protobuf/action.yaml Outdated Show resolved Hide resolved
client/protocol.py Outdated Show resolved Hide resolved
client/protocol.py Outdated Show resolved Hide resolved
tests/protocol_test.py Outdated Show resolved Hide resolved
iGxnon
iGxnon reviewed Nov 30, 2023
View reviewed changes
client/protocol.py Outdated Show resolved Hide resolved
bsbds
bsbds reviewed Dec 1, 2023
View reviewed changes
client/protocol.py Outdated Show resolved Hide resolved
iGxnon
iGxnon reviewed Dec 1, 2023
View reviewed changes
client/protocol.py Outdated Show resolved Hide resolved
bsbds
bsbds reviewed Dec 1, 2023
View reviewed changes
client/protocol.py Outdated Show resolved Hide resolved
themanforfree
themanforfree reviewed Dec 1, 2023
View reviewed changes
client/protocol.py Outdated Show resolved Hide resolved
@LingKa28 LingKa28 force-pushed the feature/protocol-client branch 3 times, most recently from f1edd18 to 344a65a Compare December 3, 2023 04:16
iGxnon
iGxnon approved these changes Dec 4, 2023
View reviewed changes
Copy link

@iGxnon iGxnon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LingKa28 LingKa28 merged commit 42e35cd into xline-kv:main Dec 4, 2023
8 checks passed
@LingKa28 LingKa28 mentioned this pull request Dec 4, 2023
Merged
@LingKa28 LingKa28 changed the title feature: protocol client feat: protocol client Dec 9, 2023
This was referenced Dec 9, 2023
Merged
Merged
@LingKa28 LingKa28 mentioned this pull request Dec 9, 2023
Merged
@LingKa28 LingKa28 deleted the feature/protocol-client branch December 9, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsbds bsbds bsbds left review comments

@themanforfree themanforfree themanforfree left review comments

@Phoenix500526 Phoenix500526 Phoenix500526 left review comments

@iGxnon iGxnon iGxnon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@LingKa28 @Phoenix500526 @themanforfree @iGxnon @bsbds