New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix when return value of Method is None #141

Merged

szymonlopaciuk merged 1 commit into xsuite:main from freddieknets:FixMethodReturnValue

Oct 9, 2024

Contributor

freddieknets commented Oct 8, 2024 •

edited

Loading

Description

Quick fix: when the return value of a Method is None, it used to still return 0; as a default case (which crashes the compilation).

Checklist

Mandatory:

I have added tests to cover my changes
All the tests are passing, including my new ones
I described my changes in this PR description

Optional:

The code I wrote follows good style practices (see PEP 8 and PEP 20).
I have updated the docs in relation to my changes, if applicable
I have tested also GPU contexts


          Quick fix

22998e4

szymonlopaciuk approved these changes

View reviewed changes

Contributor

szymonlopaciuk left a comment

It looks good to me!

szymonlopaciuk merged commit d91cd1e into xsuite:main

2 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet