Posix-ify link_receiver.cc #4229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madhurajayaraman
force-pushed
the
deprecate-link-reciever
branch
3 times, most recently
from
60f3e11
to
672213d
Compare
y4vor
reviewed
Oct 10, 2024
madhurajayaraman
force-pushed
the
deprecate-link-reciever
branch
from
e502199
to
081ddc5
Compare
madhurajayaraman
force-pushed
the
deprecate-link-reciever
branch
from
024cb8f
to
7d78cd7
Compare
jellefoks
reviewed
Oct 22, 2024
y4vor
reviewed
Oct 28, 2024
| // See https://www.ietf.org/rfc/rfc3493.txt for details. | ||
| if (local_address && (local_address->type == kSbSocketAddressTypeIpv6) && | ||
| common::MemoryIsZero(local_address->address, 16)) { | ||
| int on = 1; |
There was a problem hiding this comment.
The comments above state the IPV6_V6ONLY will be turned off. But the way I'm reading this code it is actually turning it on.
y4vor
approved these changes
Oct 28, 2024
madhurajayaraman
merged commit 53b20c5
into
youtube:pre-chrobalt
252 of 255 checks passed
madhurajayaraman
added a commit
to madhurajayaraman/cobalt
that referenced
this pull request
Oct 30, 2024
b/370776046
madhurajayaraman
added a commit
that referenced
this pull request
Nov 1, 2024
niranjanyardi
pushed a commit
that referenced
this pull request
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b/370776046