Skip tests that require kerchunk #259
Open
+146
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomNicholas
added
Kerchunk
TomNicholas
temporarily deployed
to
test-release
GitHub Actions
Inactive
TomNicholas
temporarily deployed
to
test-release
GitHub Actions
Inactive
TomNicholas
commented
Oct 17, 2024
| @@ -0,0 +1,60 @@ | |||
| name: min-deps | |||
There was a problem hiding this comment.
There was probably a better way to do this than just making an entire extra workflow file but my github-actions-fu is weak
TomNicholas
commented
Oct 17, 2024
Comment on lines
24
to
+28
| "xarray>=2024.06.0", | ||
| "kerchunk>=0.2.5", | ||
| "h5netcdf", | ||
| "numpy>=2.0.0", | ||
| "ujson", | ||
| "packaging", | ||
| "universal-pathlib", | ||
| "numcodecs", |
There was a problem hiding this comment.
The minimum set of dependencies should look like this, and you could probably even make universal-pathlib optional for reading from non-remote files...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All I've done here is skip all of those that currently require kerchunk, and add a new CI job to check that the others pass without kerchunk installed. I'm hoping that we can merge this PR then incrementally re-write all of the tests (apart from those in
test_readers/test_kerchunk.py&test_writers/test_kerchunk.py) to run and test the same functionality overall without requiring kerchunk.