-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip tests that require kerchunk #259
Open
TomNicholas
wants to merge
6
commits into
main
Choose a base branch
from
optional-kerchunk
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+146
−14
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
f5a74be
try making ujson an optional dep
TomNicholas 91be89c
skip all tests which require kerchunk
TomNicholas 90806de
add new CI job
TomNicholas 0b9b697
rename git workflow
TomNicholas 97d55cb
move numcodecs import inside
TomNicholas 379830a
add numcodecs to CI env
TomNicholas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,60 @@ | ||
name: min-deps | ||
|
||
on: | ||
push: | ||
branches: [ "main" ] | ||
paths-ignore: | ||
- 'docs/**' | ||
pull_request: | ||
branches: [ "main" ] | ||
paths-ignore: | ||
- 'docs/**' | ||
schedule: | ||
- cron: "0 0 * * *" | ||
|
||
concurrency: | ||
group: ${{ github.workflow }}-${{ github.ref }} | ||
cancel-in-progress: true | ||
|
||
jobs: | ||
|
||
test: | ||
name: ${{ matrix.python-version }}-build | ||
runs-on: ubuntu-latest | ||
defaults: | ||
run: | ||
shell: bash -l {0} | ||
strategy: | ||
matrix: | ||
python-version: ["3.12"] | ||
steps: | ||
- uses: actions/checkout@v4 | ||
|
||
- name: Setup micromamba | ||
uses: mamba-org/setup-micromamba@v1 | ||
with: | ||
environment-file: ci/min-deps.yml | ||
cache-environment: true | ||
create-args: >- | ||
python=${{matrix.python-version}} | ||
- name: Install virtualizarr | ||
run: | | ||
python -m pip install -e . --no-deps | ||
- name: Conda list information | ||
run: | | ||
conda env list | ||
conda list | ||
- name: Running Tests | ||
run: | | ||
python -m pytest ./virtualizarr --cov=./ --cov-report=xml --verbose | ||
- name: Upload code coverage to Codecov | ||
uses: codecov/[email protected] | ||
with: | ||
file: ./coverage.xml | ||
flags: unittests | ||
env_vars: OS,PYTHON | ||
name: codecov-umbrella | ||
fail_ci_if_error: false |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
name: virtualizarr-min-deps | ||
channels: | ||
- conda-forge | ||
- nodefaults | ||
dependencies: | ||
- h5netcdf | ||
- h5py | ||
- hdf5 | ||
- netcdf4 | ||
- xarray>=2024.6.0 | ||
- numpy>=2.0.0 | ||
- numcodecs | ||
- packaging | ||
- universal_pathlib | ||
# Testing | ||
- codecov | ||
- pre-commit | ||
- mypy | ||
- ruff | ||
- pandas-stubs | ||
- pytest-mypy | ||
- pytest-cov | ||
- pytest | ||
- pooch | ||
- fsspec |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,20 +22,20 @@ requires-python = ">=3.10" | |
dynamic = ["version"] | ||
dependencies = [ | ||
"xarray>=2024.06.0", | ||
"kerchunk>=0.2.5", | ||
"h5netcdf", | ||
"numpy>=2.0.0", | ||
"ujson", | ||
"packaging", | ||
"universal-pathlib", | ||
"numcodecs", | ||
Comment on lines
24
to
+28
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The minimum set of dependencies should look like this, and you could probably even make |
||
] | ||
|
||
[project.optional-dependencies] | ||
test = [ | ||
"codecov", | ||
"fastparquet", | ||
"fsspec", | ||
"h5netcdf", | ||
"h5py", | ||
"kerchunk>=0.2.5", | ||
"mypy", | ||
"netcdf4", | ||
"pandas-stubs", | ||
|
@@ -47,6 +47,7 @@ test = [ | |
"ruff", | ||
"s3fs", | ||
"scipy", | ||
"ujson", | ||
] | ||
|
||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was probably a better way to do this than just making an entire extra workflow file but my github-actions-fu is weak