Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autotest: fixed the 'X' frame #26246

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Conversation

tridge
Copy link
Contributor

@tridge tridge commented Feb 17, 2024

surprisigly, the X frame in SITL didn't work (ie. sim_vehicle.py with -f X)

@tridge tridge added the SITL label Feb 17, 2024
@IamPete1
Copy link
Member

I would have expected it to be tested as part of FlyEachFrame autotest? Do we need to fix the test to catch such things?

@tridge
Copy link
Contributor Author

tridge commented Feb 18, 2024

I would have expected it to be tested as part of FlyEachFrame autotest? Do we need to fix the test to catch such things?

that is the weird thing, it does fly, just not very well. It uses FRAME_TYPE=0 (ie. plus frame) when it is actually an X frame and does fly but oscillates

@tridge tridge merged commit e9c59bf into ArduPilot:master Feb 19, 2024
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants