Fix CubeRed and Dual Core Bootloader issues #27392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bugobliterator
commented
Jun 26, 2024
bugobliterator
commented
- Disable second core by default
- Fix bug in dual usb bootloader related to timeout.
- Rebuild bootloaders for dual core Cubes
bugobliterator
force-pushed
the
pr-fix-cubered-bootloader
branch
2 times, most recently
from
c8b7cfa
to
957775b
Compare
tridge
requested changes
Jun 26, 2024
| @@ -286,15 +286,15 @@ def configure_env(self, cfg, env): | |||
|
|
|||
| if cfg.env.DEBUG: | |||
| env.CFLAGS += [ | |||
| '-g', | |||
| '-g3', | |||
There was a problem hiding this comment.
check works on clang? or enable only on gcc
There was a problem hiding this comment.
--debug build added to CI check.
| @@ -269,6 +269,30 @@ void __early_init(void) { | |||
| STM32_NOCACHE_MPU_REGION_2_SIZE | | |||
| MPU_RASR_ENABLE); | |||
| #endif | |||
| #if defined(DUAL_CORE) | |||
There was a problem hiding this comment.
not critical, but prefer a fn in stm32_util.c
bugobliterator
force-pushed
the
pr-fix-cubered-bootloader
branch
from
957775b
to
c294a3b
Compare
bugobliterator
force-pushed
the
pr-fix-cubered-bootloader
branch
from
3f64dab
to
0424dfd
Compare
tridge
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.