add BMP390 to Navigator #27724
Merged
add BMP390 to Navigator #27724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Williangalvani
force-pushed
the
bmp390_updates
branch
from
4c08717
to
b25eb12
Compare
tridge
previously requested changes
Aug 26, 2024
libraries/AP_Baro/AP_Baro_BMP388.cpp
Outdated
| @@ -107,6 +109,9 @@ bool AP_Baro_BMP388::init() | |||
| return false; | |||
| } | |||
|
|
|||
| dev->write_register(BMP388_REG_CMD, BMP388_SOFT_RESET, true); | |||
There was a problem hiding this comment.
the true is wrong, this is not a checked register, this will reset your baro every 20 loops
There was a problem hiding this comment.
I removed this line, so now the PR only adds the new sensor to the navigator.
I tested it here and it worked fine on my board without the soft reset. If the issue comes up again, I'll open a new PR for it.
Williangalvani
force-pushed
the
bmp390_updates
branch
from
b25eb12
to
bd7f6c8
Compare
Williangalvani
force-pushed
the
bmp390_updates
branch
from
bd7f6c8
to
bfecfe7
Compare
Williangalvani
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to do these changes in order to get the BMP390 working on a new revision of the navigator.
needs testing on other platforms.
Changes are based on Adafruit's library
could it be an i2c issue? that would explain why no one else has seem the issue...