-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basis Eval at arbitrary points #1164
Conversation
06d784f
to
6716e67
Compare
59527c2
to
c1dae63
Compare
0568341
to
08fc95a
Compare
8d0f4d9
to
fdaa3f9
Compare
fdaa3f9
to
cbcf832
Compare
4e14fb0
to
1ad0850
Compare
d10fccd
to
cd08c98
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! It may be worth sketching out the implementation strategy in the documentation. It's something we'll be working on for GPU backends at some point so the math explanation won't be a waste. There will be choices about granularity. For example, the first tensor contraction could evaluate to the y-z planes of all the particles, or of a batch of particles, instead of just one particle at a time. I don't know if that's really a win.
Have you tested the pseudo-inverse approach with Q>P?
2dbced6
to
7436d4e
Compare
c728f78
to
4bcff71
Compare
5b932c7
to
35e02a7
Compare
2f11385
to
2a94f45
Compare
All backends pass now - ready to merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
woohoo
This PR adds the ability to interpolate the basis to arbitrary points:
CeedBasis
with "interpolation" from nodes to coefficients (combine interp + map to coeffs to one set of contractions)