Feature/sw 303 cx specific functionalities #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertlong13
reviewed
Sep 3, 2024
Merged
Pradeep-Carbonix
force-pushed
the
feature/SW-303-CX-specific-functionalities
branch
from
0043d40
to
399d84d
Compare
robertlong13
force-pushed
the
CxPilot-7
branch
from
2403a58
to
177753a
Compare
Allows aggregate monitors like Sum and ESC to report the minimum voltage instead of the average voltage. This is useful for systems with multiple isolated batteries where the lowest voltage is the limiting factor. SW-97
robertlong13
force-pushed
the
feature/SW-303-CX-specific-functionalities
branch
from
399d84d
to
fb4c7ce
Compare
|
[deleted comment, replaced with later update; see edit history for the old version of this] |
Added #if AP_EXTENDED_ESC_TELEM_ENABLED to enable compilation when ESCX is not defined
Added a parameter CRAN_DIR where 0 if forward and 1 or greater is reverse direction for Engine Cranking. As all our Engine our forward direction that is our default state. SW-111
when filter setting disabled
robertlong13
force-pushed
the
feature/SW-303-CX-specific-functionalities
branch
from
2d4ca0f
to
b415d39
Compare
<style>
</style>
|
- Added EFIS log for Hirth engine - Added ThM to help understand the engine logs better - Updated the field names to keep the total length 64-characters long. - Added Bitfield for the EFIS log to log all errors.
- CHT2 and EGT2 - Remove CI build error
Making changes to fix the CarboParameter CI pass for below issues Parameter 'BATT2_CURR_PIN' has an invalid value: 51 : [-1, 3, 4, 14, 15, 17, 101] Parameter 'BATT2_VOLT_PIN' has an invalid value: 50 : [-1, 2, 5, 13, 14, 16, 100] Parameter 'BATT3_CURR_PIN' has an invalid value: 52 : [-1, 3, 4, 14, 15, 17, 101] Parameter 'BATT3_VOLT_PIN' has an invalid value: 50 : [-1, 2, 5, 13, 14, 16, 100] Parameter 'CRASH_DETECT' has an invalid value: 1 : [0] Parameter 'Q_M_SPIN_ARM' has an invalid value: 0.07 : [0.0, 0.1, 0.2] SW-45
This condition was modified to fix the CI autotest error : MAV_CMD_DO_ENGINE_CONTROL 2024-09-03T04:03:41.0759926Z AT-0409.5: Exception caught: Failed to attain RPM1 want 350.0, reached 0 2024-09-03T04:03:41.0760806Z Traceback (most recent call last): 2024-09-03T04:03:41.0761962Z File "/__w/carbopilot_V2/carbopilot_V2/Tools/autotest/vehicle_test_suite.py", line 8309, in run_one_test_attempt 2024-09-03T04:03:41.0763147Z test_function(**test_kwargs) 2024-09-03T04:03:41.0764410Z File "/__w/carbopilot_V2/carbopilot_V2/Tools/autotest/quadplane.py", line 1116, in MAV_CMD_DO_ENGINE_CONTROL 2024-09-03T04:03:41.0765822Z self.wait_rpm(1, expected_starter_rpm_min, expected_starter_rpm_max) 2024-09-03T04:03:41.0767135Z File "/__w/carbopilot_V2/carbopilot_V2/Tools/autotest/vehicle_test_suite.py", line 6734, in wait_rpm 2024-09-03T04:03:41.0768213Z self.wait_and_maintain( 2024-09-03T04:03:41.0769475Z File "/__w/carbopilot_V2/carbopilot_V2/Tools/autotest/vehicle_test_suite.py", line 6902, in wait_and_maintain 2024-09-03T04:03:41.0770669Z return self.wait_and_maintain_range( 2024-09-03T04:03:41.0771877Z File "/__w/carbopilot_V2/carbopilot_V2/Tools/autotest/vehicle_test_suite.py", line 7097, in wait_and_maintain_range 2024-09-03T04:03:41.0773309Z raise AutoTestTimeoutException( 2024-09-03T04:03:41.0774319Z vehicle_test_suite.AutoTestTimeoutException: Failed to attain RPM1 want 350.0, reached 0
When #27755 was first opened, #26252 had not been merged yet. #26252 refactored a bit, but the change was not applied to #27755. This commit fixes that. This should not change the behavior of the code.
robertlong13
force-pushed
the
feature/SW-303-CX-specific-functionalities
branch
from
fa6a80c
to
38b582a
Compare
- Convert temperatures Celsius to match the docs - Fix format specifier for CHT2
There is no crankshaft sensor status reported by this EFI. This line is misleading and should be removed. The sensor health bitmask is already logged elsewhere.
The extra colons are needed in master, but not in 4.5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merged the following commits :
df00855
eed5d3f
0b2e019
5385f77
89790bf
23e5c97
f9435d2
4c49385
54fa1a0
200ea68
26b8f58
d9da9cc
0153533
de41bd6
These commits address the compiler issues :
88bfe2e
d6a91fb
0043d40
a931ea4
2d4ca0f