-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added CLI command for generating a QC report for CDM #4
Added CLI command for generating a QC report for CDM #4
Conversation
I was thinking that we could run prp just once like so:
This way we don't need to parse the outputs twice? |
I think its cleaner to keep them as separate commands as it makes it clearer what type of input is used to generate which output. CDM is also a proprietary software that other sites are not going to use. Its cleaner to not generate CDM input data by default, especially since we already have a export_to_cdm submodule. |
Yeah but the
Anyways I will create another process in the prp module if you think this is better. |
Perhaps we could add an |
@@ -86,7 +86,7 @@ def cli(): | |||
@click.option("-t", "--tbprofiler", type=click.File(), help="tbprofiler results") | |||
@click.option("--correct_alleles", is_flag=True, help="Correct alleles") | |||
@click.argument("output", type=click.File("w")) | |||
def create_output( | |||
def create_bonsai_input( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean the subarg changes from create-output
to create-bonsai-input
? I.e. prp create-bonsai-input $args
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Added a CLI command for generating the a QC report for CDM in JSON format. The PR includes a unit tests for the command.
Run
Run with
prp create-cdm-input -q quast.tsv -p bwa.qc -c chewbbaca.out sample_name
Test
pytest tests