Add TUV-x height grid updates #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d' into 95-update-tuvx-temp
boulderdaze
commented
Oct 15, 2024
|
|
||
| type(grid_t), intent(inout) :: height_grid | ||
| real(kind_phys), intent(in) :: host_midpoints(:) ! km | ||
| real(kind_phys), intent(in) :: host_edges(:) ! km |
There was a problem hiding this comment.
Is the term edge equivalent to interface? If so, can we use interface across the code base to enhance the consistency and readability?
Suggested change
| real(kind_phys), intent(in) :: host_edges(:) ! km | |
| real(kind_phys), intent(in) :: host_interface(:) ! km |
boulderdaze
commented
Oct 15, 2024
boulderdaze
commented
Oct 15, 2024
K20shores
reviewed
Oct 16, 2024
This was referenced Oct 17, 2024
nusbaume
requested changes
Oct 21, 2024
nusbaume
reviewed
Oct 22, 2024
| @@ -128,7 +129,7 @@ subroutine tuvx_run( temperature, dry_air_density, & | |||
| call calculate_heights( geopotential_height_wrt_surface_at_midpoint(i_col,:), & | |||
| geopotential_height_wrt_surface_at_interface(i_col,:), & | |||
| surface_geopotential(i_col), & | |||
| reciprocal_of_gravitational_acceleration, & | |||
| standard_gravitational_acceleration, & | |||
There was a problem hiding this comment.
I would probably recommend calculating reciprocal_of_gravitational_acceleration outside of the i_col loop and then just passing it to calculate_heights like you were doing previously (this could potentially reduce the total number of divisions that have to be done).
There was a problem hiding this comment.
I agree, thank you for the comment!
nusbaume
approved these changes
Oct 22, 2024
nusbaume
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates TUV-x height grid with CAM-SIMA state data before calculating rate constants.
Uses geopontential height values to calculate actual heights above sea level, as currently done in the CAMChem gas-phase chemistry module. If there is a better way to get these height values, we can update this PR.
Closes #94
Notes (Jiwon):
edgeswithinterfacevalgrindsuppression option to suppress memory leak issues in certain functions of TUV-x.