-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
👽️ Update GUI to match nested config for C-PAC ≥ v1.8.0 (Phase 1) #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: Fix `names`. Right now they're just the most-specific level
shnizzedy
force-pushed
the
enh/refactor-nested
branch
from
July 2, 2021 21:26
8f41e25
to
c9af2f0
Compare
shnizzedy
force-pushed
the
enh/refactor-nested
branch
from
July 16, 2021 16:22
f9e15e7
to
5124dcb
Compare
Nuisance regressors need some special handling. 🤞 Hopefully that's all that's left here. |
shnizzedy
changed the title
🚧 WIP: 👽️ Update GUI to match nested config for C-PAC ≥ v1.8.0 (Phase 1)
👽️ Update GUI to match nested config for C-PAC ≥ v1.8.0 (Phase 1)
Jul 21, 2021
3 tasks
WHEW! Incredible 👏 |
This was referenced Jul 30, 2021
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Related to #66 by @shnizzedy
Should resolve most to all of the recent @dependabot PRs (#77, #80, #81, #82, #83, #84, #85, #86, #87, #88, #89, #90, #91, #92, #93, #94)
Description
On == true
)dev/docker_data/default_pipeline.yml
changesworkhiddencorrecthiddenTechnical details
dev/docker_data/default_pipeline.yml
and automatically converts to React for the GUI based on each entry's datatype in the YAML file except for nuisance regressors, because those currently have more specific handling and validation in the GUI than in C-PAC itself.setup, anatomical preproc, functional preproc, surface, «unsorted»
to match the sequence on the cards Any top-level with arun
switch that isn't anatomical preproc, functional preproc, or surface is counted in the# derivatives
Unresolved (to do)
specialCasings
[more] comprehensive #95Tests
Run the GUI locally (
yarn run dev:browser
) and click around, make sure things behave as expected.Screenshots
new-GUI-clickthrough.mov
Checklist
Update index.md
).develop
branch of the repository.visible errors.
Developer Certificate of Origin
Developer Certificate of Origin