-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Actually initialize zero_acceleration_kinematics_placeholder_ to zero #22020
base: master
Are you sure you want to change the base?
Actually initialize zero_acceleration_kinematics_placeholder_ to zero #22020
Conversation
@drake-jenkins-bot ok to test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+@jwnimmer-tri for a quick (4 line) sampled-output-ports-related feature review, please. Is this a one-off or are there other instances we should fix?
Reviewable status: LGTM missing from assignee jwnimmer-tri(platform), needs at least two assigned reviewers, missing label for release notes (waiting on @Brian-Acosta)
I am happy to review. But it won't be as quick as four lines -- I will also need to develop and push the missing unit test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+@sherm1 for feature review, please.
(We'll assign a platform reviewer who is not me, later on.)
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: LGTM missing from assignees jwnimmer-tri(platform),sherm1(platform), commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @Brian-Acosta)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: LGTM missing from assignee jwnimmer-tri(platform), commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @Brian-Acosta)
+@ggould-tri for platform review per schedule (Tuesday), please. |
This comment in
multibody_plant.h
is lying aboutzero_acceleration_kinematics_placeholder_
getting populated with zeros :This PR fixes this issue to avoid sending NaNs from the
body_spatial_accelerations
output port on the first step of a discret-time MBP simulation.This change is