Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add: Java APIを作成 #558

Merged
merged 104 commits into from
Aug 30, 2023
Merged

Add: Java APIを作成 #558

merged 104 commits into from
Aug 30, 2023

Conversation

sevenc-nanashi
Copy link
Member

@sevenc-nanashi sevenc-nanashi commented Jul 31, 2023 •
edited
Loading

内容

Java APIをjni-rsで実装します。

関連 Issue

その他

（なし）

@sevenc-nanashi sevenc-nanashi changed the title Add: Java+gradleのセットアップ Add: Java APIを作成 Jul 31, 2023
@qryxip qryxip self-requested a review July 31, 2023 14:41
@sevenc-nanashi
Copy link
Member Author

そういえば：

このJava APIは GitHub PackagesのGradleレジストリ で配布できたら嬉しいなと思ってます。今のvoicevox_mobileはpostinstallで入れていて、少し行儀が悪いので。

@windymelt
Copy link
Contributor

いかにも良さそう。ちなみにMaven public repositoryとかにAPIのJARを置いておけると最上級に良いのですけど、これがなかなか大変なんですよね……

@qryxip qryxip mentioned this pull request Aug 17, 2023
Merged
4 tasks
@qryxip
Copy link
Member

qryxip commented Aug 18, 2023

#553 をマージしたので、少なくともgit merge mainは必要になりますね。
(Synthesizerに対するmutが完全に要らなくなったので、このままmainにマージするとwarningでCIが落ちる)

@sevenc-nanashi
Copy link
Member Author

mainをマージしました。rust-lintが通ったので大丈夫のはずです

@qryxip qryxip mentioned this pull request Aug 20, 2023
Closed
3 tasks
Hiroshiba
Hiroshiba reviewed Aug 28, 2023
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一応全部目通してみました！！お疲れ様でした！！！！！
コメントをいくつか書いていますが、多分微調整だけなので割とすぐにマージできるのかなと。

ちなみにですがこのコードを書く時どのような感じで実装されましたか？ 👀
何かをコピペして規則的に変換していったとか、あるいはPython APIとかを見ながら全部書き下したとか。

.github/workflows/generate_document.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Show resolved Hide resolved
crates/voicevox_core_java_api/README.md Outdated Show resolved Hide resolved
crates/voicevox_core_java_api/README.md Show resolved Hide resolved
crates/voicevox_core_java_api/lib/src/main/resources/dll/linux-arm64/.gitkeep Outdated Show resolved Hide resolved
crates/voicevox_core_java_api/settings.gradle Show resolved Hide resolved
crates/voicevox_core_java_api/src/common.rs Show resolved Hide resolved
crates/voicevox_core_java_api/src/common.rs Outdated Show resolved Hide resolved
crates/voicevox_core_java_api/src/user_dict.rs Outdated Show resolved Hide resolved
@sevenc-nanashi
Copy link
Member Author

sevenc-nanashi commented Aug 29, 2023 •
edited
Loading

ちなみにですがこのコードを書く時どのような感じで実装されましたか？ 👀

インターフェースはPython APIベースですが、それ以外は書き下ろしました。

Hiroshiba
Hiroshiba approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！！！！　お疲れ様でした！！！

一箇所だけコメントしているので、そのやり取りが完了したらマージかなと思います！
（あとissue作成）

@Hiroshiba
Copy link
Member

問題ないと思うのでマージしたいと思います！

（コミットメッセージ間違えました、すみません。。）

@Hiroshiba Hiroshiba merged commit 46218d9 into VOICEVOX:main Aug 30, 2023
43 checks passed
@sevenc-nanashi sevenc-nanashi mentioned this pull request Aug 30, 2023
Open
3 tasks
qryxip added a commit to qryxip/voicevox_core that referenced this pull request Sep 3, 2023
@qryxip
VOICEVOX#558 に対応
d6489cc
@qryxip qryxip mentioned this pull request Sep 3, 2023
Merged
This was referenced Sep 13, 2023
Closed
Merged
Merged
@sevenc-nanashi sevenc-nanashi mentioned this pull request Oct 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hiroshiba Hiroshiba Hiroshiba approved these changes

@qryxip qryxip qryxip approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sevenc-nanashi @Hiroshiba @qryxip @windymelt